runtime/bin/process_patch.dart - Issue 11361008: Remember to close the exitHandler when processes have received

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/process_patch.dart

Issue 11361008: Remember to close the exitHandler when processes have received (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/process_patch.dart

diff --git a/runtime/bin/process_patch.dart b/runtime/bin/process_patch.dart

index 94b36118008a5b1fbfb314328e48796c143d3256..1dd8bf63ea34589da7958c16c4c21aa6266e5c23 100644

--- a/runtime/bin/process_patch.dart

+++ b/runtime/bin/process_patch.dart

@@ -198,7 +198,10 @@ class _ProcessImpl extends NativeFieldWrapperClass1 implements Process {

exitDataRead += _exitHandler.inputStream.readInto(

exitDataBuffer, exitDataRead, EXIT_DATA_SIZE - exitDataRead);

- if (exitDataRead == EXIT_DATA_SIZE) handleExit();

+ if (exitDataRead == EXIT_DATA_SIZE) {

+ _exitHandler.close();

+ handleExit();

+ }

};

completer.complete(this);

« no previous file with comments | « no previous file | no next file » | no next file with comments »