Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1136093004: Pull polymer externs into chrome (Closed)

Created:
5 years, 7 months ago by Jeremy Klein
Modified:
5 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-polymer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pull polymer externs into chrome BUG=486240 Committed: https://crrev.com/d0550fcf3b50bdaa8e19b83f334b00a829327ef5 Cr-Commit-Position: refs/heads/master@{#329460}

Patch Set 1 #

Total comments: 1

Patch Set 2 : target a specific version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -0 lines) Patch
M third_party/polymer/v0_8/bower.json View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/polymer-externs/.bower.json View 1 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/polymer-externs/polymer.externs.js View 1 chunk +118 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components/polymer-externs/.bower.json View 1 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components/polymer-externs/polymer.externs.js View 1 chunk +118 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jeremy Klein
https://codereview.chromium.org/1136093004/diff/1/third_party/polymer/v0_8/bower.json File third_party/polymer/v0_8/bower.json (right): https://codereview.chromium.org/1136093004/diff/1/third_party/polymer/v0_8/bower.json#newcode6 third_party/polymer/v0_8/bower.json:6: "polymer-externs": "PolymerLabs/polymer-externs#master", Will switch this away from master before ...
5 years, 7 months ago (2015-05-11 23:37:16 UTC) #2
Jeremy Klein
On 2015/05/11 23:37:16, Jeremy Klein wrote: > https://codereview.chromium.org/1136093004/diff/1/third_party/polymer/v0_8/bower.json > File third_party/polymer/v0_8/bower.json (right): > > https://codereview.chromium.org/1136093004/diff/1/third_party/polymer/v0_8/bower.json#newcode6 ...
5 years, 7 months ago (2015-05-11 23:52:20 UTC) #3
michaelpg
lgtm
5 years, 7 months ago (2015-05-12 19:09:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136093004/20001
5 years, 7 months ago (2015-05-12 19:26:37 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 19:38:48 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 19:40:42 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d0550fcf3b50bdaa8e19b83f334b00a829327ef5
Cr-Commit-Position: refs/heads/master@{#329460}

Powered by Google App Engine
This is Rietveld 408576698