Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1136083002: Drop assert for degenerate cases in FloatRoundedRect::radiusCenterRect() (Closed)

Created:
5 years, 7 months ago by fs
Modified:
5 years, 7 months ago
Reviewers:
chrishtr, jbroman
CC:
blink-reviews, Rik, danakj, dshwang, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Drop assert for degenerate cases in FloatRoundedRect::radiusCenterRect() This method is only used by BoxClipper, to provide a conservative estimate of a rectangle enclosed by the rounded (inner) rectangle. Since it's unproblematic to provide a conservative estimate for the "degenerate" cases [1], do that instead of asserting. Reformulate the implementation using FloatRectOutsets. The only functional change is that there no longer is an implicit conversion from float to int. [1] As defined by isRenderable(). BUG=458505, 477826 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M Source/platform/geometry/FloatRoundedRect.cpp View 1 chunk +8 lines, -6 lines 0 comments Download
M Source/platform/geometry/FloatRoundedRectTest.cpp View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
The description briefly mentions the motivation for the removal, but to spell it out a ...
5 years, 7 months ago (2015-05-11 12:59:59 UTC) #2
chrishtr
lgtm
5 years, 7 months ago (2015-05-13 06:18:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136083002/1
5 years, 7 months ago (2015-05-13 06:18:17 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 07:30:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195299

Powered by Google App Engine
This is Rietveld 408576698