test/mjsunit/testcfg.py - Issue 1136073002: Resolve references to "this" the same way as normal variables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/mjsunit/testcfg.py

Issue 1136073002: Resolve references to "this" the same way as normal variables (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master

Patch Set: "this" should never be looked up dynamically Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/mjsunit/testcfg.py

diff --git a/test/mjsunit/testcfg.py b/test/mjsunit/testcfg.py

index 8389696f49fabf7089035ef1c9b4c5304963be79..cf4b6276e4ec159e66d40032819c0b51fd475915 100644

--- a/test/mjsunit/testcfg.py

+++ b/test/mjsunit/testcfg.py

@@ -35,6 +35,7 @@ FLAGS_PATTERN = re.compile(r"//\s+Flags:(.*)")

FILES_PATTERN = re.compile(r"//\s+Files:(.*)")

SELF_SCRIPT_PATTERN = re.compile(r"//\s+Env: TEST_FILE_NAME")

MODULE_PATTERN = re.compile(r"^// MODULE$", flags=re.MULTILINE)

+NO_HARNESS_PATTERN = re.compile(r"^// NO HARNESS$", flags=re.MULTILINE)

class MjsunitTestSuite(testsuite.TestSuite):

@@ -79,7 +80,7 @@ class MjsunitTestSuite(testsuite.TestSuite):

env = ["-e", "TEST_FILE_NAME=\"%s\"" % testfilename.replace("\\", "\\\\")]

files = env + files

- if not context.no_harness:

+ if not context.no_harness and not NO_HARNESS_PATTERN.search(source):

files.append(os.path.join(self.root, "mjsunit.js"))

if MODULE_PATTERN.search(source):

« no previous file with comments | « test/mjsunit/harmony/arrow-functions-this.js ('k') | test/mjsunit/this-dynamic-lookup.js » ('j') | no next file with comments »