test/cctest/test-serialize.cc - Issue 1136073002: Resolve references to "this" the same way as normal variables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-serialize.cc

Issue 1136073002: Resolve references to "this" the same way as normal variables (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master

Patch Set: "this" should never be looked up dynamically Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-serialize.cc

diff --git a/test/cctest/test-serialize.cc b/test/cctest/test-serialize.cc

index 1ed43ac338aa78b294b52412e33e9131bc0855b1..72eb194bae313adaaa8dc4a53f586fcbe22ea435 100644

--- a/test/cctest/test-serialize.cc

+++ b/test/cctest/test-serialize.cc

@@ -628,7 +628,7 @@ UNINITIALIZED_DEPENDENT_TEST(CustomContextDeserialization,

root =

deserializer.DeserializePartial(isolate, global_proxy,

&outdated_contexts).ToHandleChecked();

- CHECK_EQ(2, outdated_contexts->length());

+ CHECK_EQ(3, outdated_contexts->length());

CHECK(root->IsContext());

Handle<Context> context = Handle<Context>::cast(root);

CHECK(context->global_proxy() == *global_proxy);

« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | test/mjsunit/debug-scopes.js » ('j') | no next file with comments »