Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 1136073002: Resolve references to "this" the same way as normal variables (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master
Patch Set: "this" should never be looked up dynamically Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 122
123 #ifdef DEBUG 123 #ifdef DEBUG
124 if (strlen(FLAG_stop_at) > 0 && 124 if (strlen(FLAG_stop_at) > 0 &&
125 info_->function()->name()->IsUtf8EqualTo(CStrVector(FLAG_stop_at))) { 125 info_->function()->name()->IsUtf8EqualTo(CStrVector(FLAG_stop_at))) {
126 __ int3(); 126 __ int3();
127 } 127 }
128 #endif 128 #endif
129 129
130 // Sloppy mode functions need to replace the receiver with the global proxy 130 // Sloppy mode functions need to replace the receiver with the global proxy
131 // when called as functions (without an explicit receiver object). 131 // when called as functions (without an explicit receiver object).
132 if (is_sloppy(info_->language_mode()) && info()->MayUseThis() && 132 if (is_sloppy(info()->language_mode()) && info()->MayUseThis() &&
133 !info_->is_native()) { 133 !info()->is_native() && info()->scope()->has_this_declaration()) {
134 Label ok; 134 Label ok;
135 StackArgumentsAccessor args(rsp, scope()->num_parameters()); 135 StackArgumentsAccessor args(rsp, scope()->num_parameters());
136 __ movp(rcx, args.GetReceiverOperand()); 136 __ movp(rcx, args.GetReceiverOperand());
137 137
138 __ CompareRoot(rcx, Heap::kUndefinedValueRootIndex); 138 __ CompareRoot(rcx, Heap::kUndefinedValueRootIndex);
139 __ j(not_equal, &ok, Label::kNear); 139 __ j(not_equal, &ok, Label::kNear);
140 140
141 __ movp(rcx, GlobalObjectOperand()); 141 __ movp(rcx, GlobalObjectOperand());
142 __ movp(rcx, FieldOperand(rcx, GlobalObject::kGlobalProxyOffset)); 142 __ movp(rcx, FieldOperand(rcx, GlobalObject::kGlobalProxyOffset));
143 143
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 __ CallRuntime(Runtime::kNewFunctionContext, 1); 206 __ CallRuntime(Runtime::kNewFunctionContext, 1);
207 } 207 }
208 RecordSafepoint(Safepoint::kNoLazyDeopt); 208 RecordSafepoint(Safepoint::kNoLazyDeopt);
209 // Context is returned in rax. It replaces the context passed to us. 209 // Context is returned in rax. It replaces the context passed to us.
210 // It's saved in the stack and kept live in rsi. 210 // It's saved in the stack and kept live in rsi.
211 __ movp(rsi, rax); 211 __ movp(rsi, rax);
212 __ movp(Operand(rbp, StandardFrameConstants::kContextOffset), rax); 212 __ movp(Operand(rbp, StandardFrameConstants::kContextOffset), rax);
213 213
214 // Copy any necessary parameters into the context. 214 // Copy any necessary parameters into the context.
215 int num_parameters = scope()->num_parameters(); 215 int num_parameters = scope()->num_parameters();
216 for (int i = 0; i < num_parameters; i++) { 216 int first_parameter = scope()->has_this_declaration() ? -1 : 0;
217 Variable* var = scope()->parameter(i); 217 for (int i = first_parameter; i < num_parameters; i++) {
218 Variable* var = (i == -1) ? scope()->receiver() : scope()->parameter(i);
218 if (var->IsContextSlot()) { 219 if (var->IsContextSlot()) {
219 int parameter_offset = StandardFrameConstants::kCallerSPOffset + 220 int parameter_offset = StandardFrameConstants::kCallerSPOffset +
220 (num_parameters - 1 - i) * kPointerSize; 221 (num_parameters - 1 - i) * kPointerSize;
221 // Load parameter from stack. 222 // Load parameter from stack.
222 __ movp(rax, Operand(rbp, parameter_offset)); 223 __ movp(rax, Operand(rbp, parameter_offset));
223 // Store it in the context. 224 // Store it in the context.
224 int context_offset = Context::SlotOffset(var->index()); 225 int context_offset = Context::SlotOffset(var->index());
225 __ movp(Operand(rsi, context_offset), rax); 226 __ movp(Operand(rsi, context_offset), rax);
226 // Update the write barrier. This clobbers rax and rbx. 227 // Update the write barrier. This clobbers rax and rbx.
227 if (need_write_barrier) { 228 if (need_write_barrier) {
(...skipping 5724 matching lines...) Expand 10 before | Expand all | Expand 10 after
5952 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5953 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5953 RecordSafepoint(Safepoint::kNoLazyDeopt); 5954 RecordSafepoint(Safepoint::kNoLazyDeopt);
5954 } 5955 }
5955 5956
5956 5957
5957 #undef __ 5958 #undef __
5958 5959
5959 } } // namespace v8::internal 5960 } } // namespace v8::internal
5960 5961
5961 #endif // V8_TARGET_ARCH_X64 5962 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698