Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: src/variables.cc

Issue 1136073002: Resolve references to "this" the same way as normal variables (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master
Patch Set: "this" should never be looked up dynamically Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/scopes.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/ast.h" 7 #include "src/ast.h"
8 #include "src/scopes.h" 8 #include "src/scopes.h"
9 #include "src/variables.h" 9 #include "src/variables.h"
10 10
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 maybe_assigned_(maybe_assigned_flag) { 52 maybe_assigned_(maybe_assigned_flag) {
53 // Var declared variables never need initialization. 53 // Var declared variables never need initialization.
54 DCHECK(!(mode == VAR && initialization_flag == kNeedsInitialization)); 54 DCHECK(!(mode == VAR && initialization_flag == kNeedsInitialization));
55 } 55 }
56 56
57 57
58 bool Variable::IsGlobalObjectProperty() const { 58 bool Variable::IsGlobalObjectProperty() const {
59 // Temporaries are never global, they must always be allocated in the 59 // Temporaries are never global, they must always be allocated in the
60 // activation frame. 60 // activation frame.
61 return (IsDynamicVariableMode(mode_) || 61 return (IsDynamicVariableMode(mode_) ||
62 (IsDeclaredVariableMode(mode_) && !IsLexicalVariableMode(mode_))) 62 (IsDeclaredVariableMode(mode_) && !IsLexicalVariableMode(mode_))) &&
63 && scope_ != NULL && scope_->is_script_scope(); 63 scope_ != NULL && scope_->is_script_scope() && !is_this();
64 } 64 }
65 65
66 66
67 int Variable::CompareIndex(Variable* const* v, Variable* const* w) { 67 int Variable::CompareIndex(Variable* const* v, Variable* const* w) {
68 int x = (*v)->index(); 68 int x = (*v)->index();
69 int y = (*w)->index(); 69 int y = (*w)->index();
70 // Consider sorting them according to type as well? 70 // Consider sorting them according to type as well?
71 return x - y; 71 return x - y;
72 } 72 }
73 73
74 } } // namespace v8::internal 74 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/scopes.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698