Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1136053003: Check whether Java bitmap memory size is same to one of SkBitmap (Closed)

Created:
5 years, 7 months ago by Jaekyun Seok (inactive)
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check whether Java bitmap memory size is same to one of SkBitmap This is to understand why Issue 476559 is happening. BUG=476559 Committed: https://crrev.com/a1d10e49da54d73e112c0a378b342bd73fa0f3a7 Cr-Commit-Position: refs/heads/master@{#329288}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use static_cast<int> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M ui/android/java/src/org/chromium/ui/gfx/BitmapHelper.java View 2 chunks +5 lines, -1 line 0 comments Download
M ui/gfx/android/java_bitmap.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/gfx/android/java_bitmap.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Jaekyun Seok (inactive)
jdduke@ and dtrainor@, could you please review this CL?
5 years, 7 months ago (2015-05-11 20:03:51 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 7 months ago (2015-05-11 22:11:20 UTC) #3
jdduke (slow)
Also lgtm. https://codereview.chromium.org/1136053003/diff/1/ui/gfx/android/java_bitmap.cc File ui/gfx/android/java_bitmap.cc (right): https://codereview.chromium.org/1136053003/diff/1/ui/gfx/android/java_bitmap.cc#newcode112 ui/gfx/android/java_bitmap.cc:112: CHECK_EQ(jbitmap.byte_count(), (int) skbitmap.getSize()); nit: static_cast<int>
5 years, 7 months ago (2015-05-11 22:14:49 UTC) #4
Jaekyun Seok (inactive)
https://codereview.chromium.org/1136053003/diff/1/ui/gfx/android/java_bitmap.cc File ui/gfx/android/java_bitmap.cc (right): https://codereview.chromium.org/1136053003/diff/1/ui/gfx/android/java_bitmap.cc#newcode112 ui/gfx/android/java_bitmap.cc:112: CHECK_EQ(jbitmap.byte_count(), (int) skbitmap.getSize()); On 2015/05/11 22:14:49, jdduke wrote: > ...
5 years, 7 months ago (2015-05-11 23:07:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136053003/20001
5 years, 7 months ago (2015-05-11 23:08:10 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 00:11:10 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 00:12:42 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a1d10e49da54d73e112c0a378b342bd73fa0f3a7
Cr-Commit-Position: refs/heads/master@{#329288}

Powered by Google App Engine
This is Rietveld 408576698