Ensure that favicons always have 1x representation regardless of whether the platform supports it

chrome/browser/favicon/favicon_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/favicon/favicon_util.h"
 
 #include "chrome/browser/history/history_types.h"
 #include "chrome/browser/history/select_favicon_frames.h"
 #include "chrome/common/icon_messages.h"
 #include "content/public/browser/render_view_host.h"
 #include "googleurl/src/gurl.h"
 #include "ui/gfx/codec/png_codec.h"
 #include "ui/gfx/image/image_skia.h"
 
 // static
+std::vector<ui::ScaleFactor> FaviconUtil::GetFaviconScaleFactors() {
+  static std::vector<ui::ScaleFactor>* favicon_scale_factors =

[sky, 2012/11/15 18:14:54]

Is it really worth caching this? If we do, it means any tests that reset the
scale factors and then call this would have problems.

+      new std::vector<ui::ScaleFactor>();
+  if (favicon_scale_factors->empty()) {
+    favicon_scale_factors->push_back(ui::SCALE_FACTOR_100P);
+
+    std::vector<ui::ScaleFactor> supported_scale_factors =
+        ui::GetSupportedScaleFactors();
+    for (size_t i = 0; i < supported_scale_factors.size(); ++i) {
+      ui::ScaleFactor scale_factor = supported_scale_factors[i];
+      if (scale_factor != ui::SCALE_FACTOR_100P)
+        favicon_scale_factors->push_back(scale_factor);
+    }
+  }
+  return *favicon_scale_factors;
+}
+
+// static
 int FaviconUtil::DownloadFavicon(content::RenderViewHost* rvh,
                                  const GURL& url,
                                  int image_size) {
   static int id = 0;
   rvh->Send(new IconMsg_DownloadFavicon(rvh->GetRoutingID(), ++id, url,
             image_size));
   return id;
 }
 // static
 gfx::Image FaviconUtil::SelectFaviconFramesFromPNGs(
@@ skipping 10 matching lines @@
                               png_data[i].bitmap_data->size(),
                               &bitmap)) {
       bitmaps.push_back(bitmap);
     }
   }
 
   if (bitmaps.empty())
     return gfx::Image();
 
   gfx::ImageSkia resized_image_skia = SelectFaviconFrames(bitmaps,
-      ui::GetSupportedScaleFactors(), favicon_size, NULL);
+      scale_factors, favicon_size, NULL);
   return gfx::Image(resized_image_skia);
 }