sdk/lib/_internal/compiler/implementation/lib/interceptors.dart - Issue 11360228: Simplify runtime type support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/interceptors.dart

Issue 11360228: Simplify runtime type support. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/lib/interceptors.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/interceptors.dart b/sdk/lib/_internal/compiler/implementation/lib/interceptors.dart

index 1f00319e21612daee86dabc0abb3b58b85188bdf..66bc17ed7ce433161122922dd3aee13a6ee19875 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/interceptors.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/interceptors.dart

@@ -580,7 +580,7 @@ get$runtimeType(receiver) {

} else if (receiver == null) {

return createRuntimeType('Null');

} else if (isJsArray(receiver)) {

- return createRuntimeType('List');

+ return createRuntimeType(getRuntimeTypeString(receiver));

ngeoffray 2012/11/16 13:47:35 Add a comment that this is because List might be p

karlklose 2012/11/20 10:35:26 Done.

} else {

return UNINTERCEPTED(receiver.runtimeType);

}