Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Unified Diff: chrome/common/cloud_print/cloud_print_consts.cc

Issue 11360151: Move common cloud print methods from service/cloud_print to common/cloud_print. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/cloud_print/cloud_print_consts.cc
diff --git a/chrome/common/cloud_print/cloud_print_consts.cc b/chrome/common/cloud_print/cloud_print_consts.cc
new file mode 100644
index 0000000000000000000000000000000000000000..eb67ed5b2e6ba64ee48098362c9d8ff8c3c2f76d
--- /dev/null
+++ b/chrome/common/cloud_print/cloud_print_consts.cc
@@ -0,0 +1,46 @@
+// Copyright 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/cloud_print/cloud_print_consts.h"
+
+namespace cloud_print {
+
+// Values in parameters when updating or registering a printer at cloud print
msw 2012/11/09 23:18:17 nit: remove duplicated comments.
Chen Yu 2012/11/13 14:02:15 Done.
+// server.
+const char kProxyIdValue[] = "proxy";
+const char kPrinterNameValue[] = "printer";
+const char kPrinterDescValue[] = "description";
+const char kPrinterCapsValue[] = "capabilities";
+const char kPrinterDefaultsValue[] = "defaults";
+const char kPrinterStatusValue[] = "status";
+const char kPrinterTagValue[] = "tag";
+const char kPrinterRemoveTagValue[] = "remove_tag";
+const char kMessageTextValue[] = "message";
+
+// Values in the respone JSON from the cloud print server
msw 2012/11/09 23:18:17 nit: remove duplicated comments.
Chen Yu 2012/11/13 14:02:15 Done.
+const char kSuccessValue[] = "success";
+const char kNameValue[] = "name";
+const char kIdValue[] = "id";
+const char kTicketUrlValue[] = "ticketUrl";
+const char kFileUrlValue[] = "fileUrl";
+const char kPrinterListValue[] = "printers";
+const char kJobListValue[] = "jobs";
+const char kTitleValue[] = "title";
+const char kPrinterCapsHashValue[] = "capsHash";
+const char kTagsValue[] = "tags";
+const char kXMPPJidValue[] = "xmpp_jid";
+const char kOAuthCodeValue[] = "authorization_code";
+const char kCreateTimeValue[] = "createTime";
+const char kPrinterTypeValue[] = "type";
+
+// Printer tag names. Don't need prefixes. They will be added on submit.
msw 2012/11/09 23:18:17 nit: put this comment in the header; split the lis
Chen Yu 2012/11/13 14:02:15 Done.
+const char kChromeVersionTagName[] = "chrome_version";
+const char kSystemNameTagName[] = "system_name";
+const char kSystemVersionTagName[] = "system_version";
+
+// Certain cloud print requests require Chrome's X-CloudPrint-Proxy header.
msw 2012/11/09 23:18:17 nit: put this comment in the header.
Chen Yu 2012/11/13 14:02:15 Done.
+const char kChromeCloudPrintProxyHeader[] = "X-CloudPrint-Proxy: Chrome";
+
+} // namespace cloud_print
+

Powered by Google App Engine
This is Rietveld 408576698