Move common cloud print methods from service/cloud_print to common/cloud_print.

chrome/common/cloud_print/cloud_print_helpers_unittest.cc

Index: chrome/common/cloud_print/cloud_print_helpers_unittest.cc
diff --git a/chrome/common/cloud_print/cloud_print_helpers_unittest.cc b/chrome/common/cloud_print/cloud_print_helpers_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5a7bbbc19d6417179f8d296dd73f2e3f633be589
--- /dev/null
+++ b/chrome/common/cloud_print/cloud_print_helpers_unittest.cc
@@ -0,0 +1,130 @@
+// Copyright 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/cloud_print/cloud_print_helpers.h"
+
+#include <vector>

[msw, 2012/11/29 19:57:36]

nit: vector appears to be unused here, but i may be wrong.

[Chen Yu, 2012/11/30 17:35:46]

Done.

+
+#include "base/md5.h"
+#include "base/stringprintf.h"
+#include "base/sys_info.h"
+#include "chrome/common/chrome_version_info.h"
+#include "googleurl/src/gurl.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace cloud_print {
+
+void CheckURLs(const GURL& server_base_url) {

[msw, 2012/11/29 19:57:36]

optional nit: keep CheckURLs and the tests within an anonymous namespace within
the cloud_print namespace, just to reinforce that they're only used locally.

[Chen Yu, 2012/11/30 17:35:46]

Done.

+  std::string expected_url_base = server_base_url.spec();
+  if (expected_url_base[expected_url_base.length() - 1] != '/')
+    expected_url_base += "/";
+
+  EXPECT_EQ(base::StringPrintf("%ssearch", expected_url_base.c_str()),
+            GetUrlForSearch(server_base_url).spec());
+
+  EXPECT_EQ(base::StringPrintf("%ssubmit", expected_url_base.c_str()),
+            GetUrlForSubmit(server_base_url).spec());
+
+  EXPECT_EQ(base::StringPrintf("%slist?proxy=demoproxy",
+                expected_url_base.c_str()),
+            GetUrlForPrinterList(
+                server_base_url, std::string("demoproxy")).spec());
+
+  EXPECT_EQ(base::StringPrintf("%sregister", expected_url_base.c_str()),
+            GetUrlForPrinterRegistration(server_base_url).spec());
+
+  EXPECT_EQ(base::StringPrintf("%supdate?printerid=printeridfoo",
+                expected_url_base.c_str()),
+            GetUrlForPrinterUpdate(server_base_url, "printeridfoo").spec());
+
+  EXPECT_EQ(base::StringPrintf("%sdelete?printerid=printeridbar&reason=deleted",
+                expected_url_base.c_str()),
+            GetUrlForPrinterDelete(
+                server_base_url, "printeridbar", "deleted").spec());
+
+  EXPECT_EQ(base::StringPrintf("%sfetch?printerid=myprinter&deb=nogoodreason",
+                expected_url_base.c_str()),
+            GetUrlForJobFetch(
+                server_base_url, "myprinter", "nogoodreason").spec());
+
+  EXPECT_EQ(base::StringPrintf("%sdeletejob?jobid=myprinter",
+                expected_url_base.c_str()),
+            GetUrlForJobDelete(server_base_url, "myprinter").spec());
+
+  EXPECT_EQ(base::StringPrintf("%scontrol?jobid=myprinter&status=s1",
+                expected_url_base.c_str()),
+            GetUrlForJobStatusUpdate(
+                server_base_url, "myprinter", "s1").spec());
+
+  EXPECT_EQ(base::StringPrintf("%smessage?code=testmsg",
+                expected_url_base.c_str()),
+            GetUrlForUserMessage(server_base_url, "testmsg").spec());
+
+  EXPECT_EQ(base::StringPrintf(
+                "%screaterobot?oauth_client_id=democlientid&proxy=demoproxy",
+                expected_url_base.c_str()),
+            GetUrlForGetAuthCode(
+                server_base_url, "democlientid", "demoproxy").spec());
+}
+
+TEST(CloudPrintHelpersTest, GetURLs) {
+  CheckURLs(GURL("https://www.google.com/cloudprint"));
+  CheckURLs(GURL("https://www.google.com/cloudprint/"));
+  CheckURLs(GURL("http://www.myprinterserver.com"));
+  CheckURLs(GURL("http://www.myprinterserver.com/"));
+}
+
+TEST(CloudPrintHelpersTest, GetHashOfPrinterTags) {
+  PrinterTags printer_tags;
+  printer_tags["tag1"] = std::string("value1");
+  printer_tags["tag2"] = std::string("value2");
+
+  chrome::VersionInfo version_info;
+  std::string expected_list_string = StringPrintf(
+      "chrome_version%ssystem_name%ssystem_version%stag1value1tag2value2",
+      version_info.CreateVersionString().c_str(),
+      base::SysInfo::OperatingSystemName().c_str(),
+      base::SysInfo::OperatingSystemVersion().c_str());
+  EXPECT_EQ(base::MD5String(expected_list_string),
+            GetHashOfPrinterTags(printer_tags));
+}
+
+TEST(CloudPrintHelpersTest, GetPostDataForPrinterTags) {
+  PrinterTags printer_tags;
+  printer_tags["tag1"] = std::string("value1");
+  printer_tags["tag2"] = std::string("value2");
+
+  chrome::VersionInfo version_info;
+  std::string expected = base::StringPrintf(
+      "--test_mime_boundary\r\nContent-Disposition: form-data; name=\"tag\""
+      "\r\n\r\n__test__chrome_version=%s\r\n"
+      "--test_mime_boundary\r\nContent-Disposition: form-data; name=\"tag\""
+      "\r\n\r\n__test__system_name=%s\r\n"
+      "--test_mime_boundary\r\nContent-Disposition: form-data; name=\"tag\""
+      "\r\n\r\n__test__system_version=%s\r\n"
+      "--test_mime_boundary\r\nContent-Disposition: form-data; name=\"tag\""
+      "\r\n\r\n__test__tag1=value1\r\n"
+      "--test_mime_boundary\r\nContent-Disposition: form-data; name=\"tag\""
+      "\r\n\r\n__test__tag2=value2\r\n"
+      "--test_mime_boundary\r\nContent-Disposition: form-data; name=\"tag\""
+      "\r\n\r\n__test__tagshash=%s\r\n",
+      version_info.CreateVersionString().c_str(),
+      base::SysInfo::OperatingSystemName().c_str(),
+      base::SysInfo::OperatingSystemVersion().c_str(),
+      GetHashOfPrinterTags(printer_tags).c_str());
+
+  EXPECT_EQ(expected, GetPostDataForPrinterTags(
+      printer_tags,
+      std::string("test_mime_boundary"),
+      std::string("__test__"),
+      std::string("__test__tagshash")));
+}
+
+TEST(CloudPrintHelpersTest, GetCloudPrintAuthHeader) {
+  std::string test_auth("testauth");
+  EXPECT_EQ("Authorization: OAuth testauth",
+            GetCloudPrintAuthHeader(test_auth));
+}
+
+}  // namespace cloud_print