Move common cloud print methods from service/cloud_print to common/cloud_print.

chrome/service/cloud_print/cloud_print_url_fetcher.cc

Index: chrome/service/cloud_print/cloud_print_url_fetcher.cc
diff --git a/chrome/service/cloud_print/cloud_print_url_fetcher.cc b/chrome/service/cloud_print/cloud_print_url_fetcher.cc
index 77a37ce35e05181b2db2e70bc0f7f610c97ff2f0..fcb75a12ec755b08d17a4091291bede46bda24a8 100644
--- a/chrome/service/cloud_print/cloud_print_url_fetcher.cc
+++ b/chrome/service/cloud_print/cloud_print_url_fetcher.cc
@@ -6,6 +6,7 @@
 
 #include "base/stringprintf.h"
 #include "base/values.h"
+#include "chrome/common/cloud_print/cloud_print_constants.h"
 #include "chrome/common/cloud_print/cloud_print_helpers.h"
 #include "chrome/service/cloud_print/cloud_print_consts.h"

[msw, 2012/11/17 00:22:30]

ditto nit: remove this include if unused.

[Chen Yu, 2012/11/26 12:07:06]

Done.

 #include "chrome/service/cloud_print/cloud_print_helpers.h"
@@ -208,7 +209,7 @@ net::URLRequestContextGetter* CloudPrintURLFetcher::GetRequestContextGetter() {
       g_service_process->GetServiceURLRequestContextGetter();
   // Now set up the user agent for cloudprint.
   std::string user_agent = getter->user_agent();
-  base::StringAppendF(&user_agent, " %s", kCloudPrintUserAgent);
+  base::StringAppendF(&user_agent, " %s", cloud_print::kCloudPrintUserAgent);

[msw, 2012/11/17 00:22:30]

ditto nit: put this file in the cloud_print namespace and remove the specifiers.

[Chen Yu, 2012/11/26 12:07:06]

Done.

   getter->set_user_agent(user_agent);
   return getter;
 }