Move common cloud print methods from service/cloud_print to common/cloud_print.

chrome/common/cloud_print/cloud_print_constants.h

Index: chrome/common/cloud_print/cloud_print_constants.h
diff --git a/chrome/common/cloud_print/cloud_print_constants.h b/chrome/common/cloud_print/cloud_print_constants.h
new file mode 100644
index 0000000000000000000000000000000000000000..65c58e2ca80910ebd68ee0a1220d289001df60a7
--- /dev/null
+++ b/chrome/common/cloud_print/cloud_print_constants.h
@@ -0,0 +1,65 @@
+// Copyright 2012 The Chromium Authors. All rights reserved.

[msw, 2012/11/17 00:22:30]

Why are you omitting and removing (c) from some files? Please be consistent.

[Chen Yu, 2012/11/26 12:07:06]

This file is actually new created, and it is to follow
https://code.google.com/p/chromium/issues/detail?id=140977
(I undo the (c) removal in other files)

On 2012/11/17 00:22:30, msw wrote:

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_COMMON_CLOUD_PRINT_CLOUD_PRINT_CONSTANTS_H_
+#define CHROME_COMMON_CLOUD_PRINT_CLOUD_PRINT_CONSTANTS_H_
+
+#include "base/basictypes.h"
+
+namespace cloud_print {
+
+// The string to be appended to the user-agent for cloudprint requests.

[msw, 2012/11/17 00:22:30]

nit: "cloud print"

[Chen Yu, 2012/11/26 12:07:06]

Done.

+extern const char kCloudPrintUserAgent[];
+// The proxy header required by cloud print server.
+extern const char kChromeCloudPrintProxyHeader[];
+// The service id of cloud print used in gaia authentication.
+extern const char kCloudPrintGaiaServiceId[];
+// The user agent string used in gaia authentication.
+extern const char kProxyAuthUserAgent[];
+// The source of cloud print notifications.
+extern const char kCloudPrintPushNotificationsSource[];
+
+// Values in parameters when updating or registering a printer at cloud print

[msw, 2012/11/17 00:22:30]

nit: use the original comment or consider:
"Values used to register or update a printer with the cloud print service."

[Chen Yu, 2012/11/26 12:07:06]

Done.

+// server.
+extern const char kProxyIdValue[];
+extern const char kPrinterNameValue[];
+extern const char kPrinterDescValue[];
+extern const char kPrinterCapsValue[];
+extern const char kPrinterDefaultsValue[];
+extern const char kPrinterStatusValue[];
+extern const char kPrinterTagValue[];
+extern const char kPrinterRemoveTagValue[];
+extern const char kMessageTextValue[];
+
+// Value of "code" parameter in cloud print "/message" requests.
+extern const char kPrintSystemFailedMessageId[];
+extern const char kGetPrinterCapsFailedMessageId[];
+extern const char kEnumPrintersFailedMessageId[];
+extern const char kZombiePrinterMessageId[];
+
+// Values in the respone JSON from the cloud print server.
+extern const char kSuccessValue[];
+extern const char kNameValue[];
+extern const char kIdValue[];
+extern const char kTicketUrlValue[];
+extern const char kFileUrlValue[];
+extern const char kPrinterListValue[];
+extern const char kJobListValue[];
+extern const char kTitleValue[];
+extern const char kPrinterCapsHashValue[];
+extern const char kTagsValue[];
+extern const char kXMPPJidValue[];
+extern const char kOAuthCodeValue[];
+extern const char kCreateTimeValue[];
+extern const char kPrinterTypeValue[];
+
+// Printer tag names. Don't need prefixes. They will be added on submit.
+extern const char kChromeVersionTagName[];
+extern const char kSystemNameTagName[];
+extern const char kSystemVersionTagName[];
+
+}  // namespace cloud_print
+
+#endif  // CHROME_COMMON_CLOUD_PRINT_CLOUD_PRINT_CONSTANTS_H_
+