Move common cloud print methods from service/cloud_print to common/cloud_print.

chrome/service/cloud_print/cloud_print_helpers.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_SERVICE_CLOUD_PRINT_CLOUD_PRINT_HELPERS_H_

[msw, 2012/11/09 23:18:17]

I know I originally split up this file into
chrome/common/cloud_print/cloud_print_helpers.h|cc to access a subset of
helpers, but at this point I'd suggest moving the remainder of this file there
to consolidate the helpers in one spot (presuming there's nothing
service-dependent here).

[Chen Yu, 2012/11/13 14:02:15]

I moved most of them except those depends on 
(1) PrintJobStatus or PrintJobDetails (they are defined in service: 
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/service/cloud_print...),

and (2) TokenStore
(http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/service/cloud_print...)

On 2012/11/09 23:18:17, msw wrote:

[msw, 2012/11/17 00:22:30]

sounds good.

 #define CHROME_SERVICE_CLOUD_PRINT_CLOUD_PRINT_HELPERS_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "chrome/service/cloud_print/print_system.h"
 #include "googleurl/src/gurl.h"
 
 namespace base {
 class DictionaryValue;
 }
 
 // Helper methods for the cloud print proxy code.
 class CloudPrintHelpers {
  public:
-  static GURL GetUrlForPrinterRegistration(const GURL& cloud_print_server_url);
-  static GURL GetUrlForPrinterUpdate(const GURL& cloud_print_server_url,
-                                     const std::string& printer_id);
-  static GURL GetUrlForPrinterDelete(const GURL& cloud_print_server_url,
-                                     const std::string& printer_id,
-                                     const std::string& reason);
-  static GURL GetUrlForPrinterList(const GURL& cloud_print_server_url,
-                                   const std::string& proxy_id);
-  static GURL GetUrlForJobFetch(const GURL& cloud_print_server_url,
-                                const std::string& printer_id,
-                                const std::string& reason);
   static GURL GetUrlForJobStatusUpdate(const GURL& cloud_print_server_url,
                                        const std::string& job_id,
                                        cloud_print::PrintJobStatus status);
   static GURL GetUrlForJobStatusUpdate(
       const GURL& cloud_print_server_url,
       const std::string& job_id,
       const cloud_print::PrintJobDetails& details);
-  static GURL GetUrlForUserMessage(const GURL& cloud_print_server_url,
-                                   const std::string& message_id);
-  static GURL GetUrlForGetAuthCode(const GURL& cloud_print_server_url,
-                                   const std::string& oauth_client_id,
-                                   const std::string& proxy_id);
 
   // Returns an MD5 hash for printer tags.
   static std::string GetHashOfPrinterTags(
       const printing::PrinterBasicInfo& printer);
   // Returns an post data for printer tags.
   static std::string GetPostDataForPrinterTags(
       const printing::PrinterBasicInfo& printer_info,
       const std::string& mime_boundary);
 
   // Returns true is tags indicate a dry run (test) job.
   static bool IsDryRunJob(const std::vector<std::string>& tags);
 
   // Created CloudPrint auth header from the auth token stored in the store.
   static std::string GetCloudPrintAuthHeaderFromStore();
   // Created CloudPrint auth header from the auth token.
   static std::string GetCloudPrintAuthHeader(const std::string& auth_token);
 
  private:
   CloudPrintHelpers() {}
 };
 
 #endif  // CHROME_SERVICE_CLOUD_PRINT_CLOUD_PRINT_HELPERS_H_