Move common cloud print methods from service/cloud_print to common/cloud_print.

chrome/service/cloud_print/cloud_print_consts.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_SERVICE_CLOUD_PRINT_CLOUD_PRINT_CONSTS_H_

[msw, 2012/11/09 23:18:17]

For a simple constants file, I'd suggest just moving the whole file to
chrome/common, instead of splitting it up (then you can also ignore my nits
therein if you wish).

[Chen Yu, 2012/11/13 14:02:15]

Thanks for the suggestions! I moved those not service specific constants to
browser/common/cloud_print

There are still some in service/cloud_print/cloud_print_consts.h. (Here is the
link for the convenience:
https://codereview.chromium.org/11360151/diff/7007/chrome/service/cloud_print...)

One section is about tag names; they are different for different usage (for
example, we use "__apns__" for ios in chrome_to_mobile job receiving)

One is about the strings for the reasons of job fetching. I think they could be
different in different scenarios. So I keep them there.

The rest is about retry limit and waiting time. I keep them there as I think
they could be different in different usages.

What do you think? Thank you!


On 2012/11/09 23:18:17, msw wrote:

[msw, 2012/11/17 00:22:30]

I'd marginally prefer to keep all the constants defined together, even if some
are only used within chrome/service, just so there's a single constants file.
That said, it's really up to cloud print OWNERS.

[Chen Yu, 2012/11/26 12:07:06]

Done.

 #define CHROME_SERVICE_CLOUD_PRINT_CLOUD_PRINT_CONSTS_H_
 
 #include "base/basictypes.h"
 
-// Constant defines used in the cloud print proxy code
-extern const char kProxyIdValue[];
-extern const char kPrinterNameValue[];
-extern const char kPrinterDescValue[];
-extern const char kPrinterCapsValue[];
-extern const char kPrinterDefaultsValue[];
-extern const char kPrinterStatusValue[];
-extern const char kPrinterTagValue[];
-extern const char kPrinterRemoveTagValue[];
-extern const char kMessageTextValue[];
-
-// Values in the respone JSON from the cloud print server
-extern const char kNameValue[];
-extern const char kIdValue[];
-extern const char kTicketUrlValue[];
-extern const char kFileUrlValue[];
-extern const char kJobListValue[];
-extern const char kTitleValue[];
-extern const char kPrinterCapsHashValue[];
-extern const char kTagsValue[];
-extern const char kXMPPJidValue[];
-extern const char kOAuthCodeValue[];
-
 extern const char kProxyTagPrefix[];
 extern const char kTagsHashTagName[];
 extern const char kTagDryRunFlag[];
-extern const char kChromeVersionTagName[];
-extern const char kSystemNameTagName[];
-extern const char kSystemVersionTagName[];
 
 extern const char kCloudPrintGaiaServiceId[];
 extern const char kProxyAuthUserAgent[];
 extern const char kCloudPrintPushNotificationsSource[];
 extern const char kCloudPrintUserAgent[];
 extern const char kJobFetchReasonStartup[];
 extern const char kJobFetchReasonPoll[];
 extern const char kJobFetchReasonNotified[];
 extern const char kJobFetchReasonQueryMore[];
 extern const char kPrintSystemFailedMessageId[];
@@ skipping 23 matching lines @@
 
 // Number of failed pings before we try to reinstablish XMPP connection.
 const int kMaxFailedXmppPings = 2;
 
 // The number of seconds before the OAuth2 access token is due to expire that
 // we try and refresh it.
 const int kTokenRefreshGracePeriodSecs = 5*60;  // 5 minutes in seconds
 
 #endif  // CHROME_SERVICE_CLOUD_PRINT_CLOUD_PRINT_CONSTS_H_