Issue 11360145: cc: The SolidColorLayer should report contentsOpaque() true when its color is opaque

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11360145: cc: The SolidColorLayer should report contentsOpaque() true when its color is opaque (Closed)

Created:
8 years, 1 month ago by danakj

Modified:
8 years, 1 month ago

Reviewers:
jamesr

CC:
chromium-reviews, cc-bugs_chromium.org, piman, backer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: The SolidColorLayer should report contentsOpaque() true when its color is opaque This is required for the layer to occlude other things. Currently the layer never occludes anything. Tests: cc_unittests:SolidColorLayerImplTest.verifyOpaqueRect BUG=159745 R=jamesr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166690

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -1 line)			Patch
M	cc/layer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cc/solid_color_layer.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/solid_color_layer.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	cc/solid_color_layer_impl_unittest.cc	View	2 chunks	+61 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11360145/1

8 years, 1 month ago (2012-11-08 02:51:50 UTC) #3

commit-bot: I haz the power

Retried try job too often for step(s) browser_tests

8 years, 1 month ago (2012-11-08 08:10:50 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11360145/1

8 years, 1 month ago (2012-11-08 17:00:07 UTC) #5

commit-bot: I haz the power

8 years, 1 month ago (2012-11-08 17:19:08 UTC) #6

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

Expand Messages | Collapse Messages