Issue 11360130: Improve warnings about 32bit libs on 64bit systems.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11360130: Improve warnings about 32bit libs on 64bit systems. (Closed)

Created:
8 years, 1 month ago by Michael Moss

Modified:
8 years, 1 month ago

Reviewers:
scroggo_chromium, tapted, scroggo, Markus (顧孟勤)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Improve warnings about 32bit libs on 64bit systems. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166488

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -15 lines)			Patch
	M	build/install-build-deps.sh	View		1 chunk	+21 lines, -15 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tapted

sure you will notice soon ;) Also wondering whether I need libglade2-dev for ../../gpu/gles2_conform_support/native/egl_native_linux.cc:7:22: fatal ...

8 years, 1 month ago (2012-11-07 22:24:29 UTC) #3

Michael Moss

8 years, 1 month ago (2012-11-07 22:57:10 UTC) #4

https://codereview.chromium.org/11360130/diff/1/build/install-build-deps.sh
File build/install-build-deps.sh (right):

https://codereview.chromium.org/11360130/diff/1/build/install-build-deps.sh#n...
build/install-build-deps.sh:252: if test "$do_inst_lib32" != "1"
On 2012/11/07 22:24:29, tapted wrote:
> missing `; then` ?

Ugh, thanks. https://codereview.chromium.org/11360134/

Expand Messages | Collapse Messages