Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: runtime/bin/bin.gypi

Issue 11360121: When building standalone Dart executable, put implementation of dart:io natives in a separate libra… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/builtin.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/bin.gypi
diff --git a/runtime/bin/bin.gypi b/runtime/bin/bin.gypi
index 3cde1ee1bf67c861a87526da133c6ff97c39aa32..b9658b617489972141ac229cacd34945609ec429 100644
--- a/runtime/bin/bin.gypi
+++ b/runtime/bin/bin.gypi
@@ -267,6 +267,7 @@
'sources': [
'builtin_natives.cc',
'builtin.h',
+ 'io_natives.h',
],
'includes': [
'builtin_impl_sources.gypi',
@@ -303,6 +304,36 @@
],
},
{
+ 'target_name': 'libdart_io',
+ 'type': 'static_library',
+ 'include_dirs': [
+ '..',
+ ],
+ 'sources': [
+ 'io_natives.h',
+ 'io_natives.cc',
+ ],
+ 'includes': [
+ 'io_impl_sources.gypi',
+ ],
+ 'conditions': [
+ ['OS=="win"', {
+ # TODO(antonm): fix the implementation.
+ # Current implementation accepts char* strings
+ # and therefore fails to compile once _UNICODE is
+ # enabled. That should be addressed using -A
+ # versions of functions and adding necessary conversions.
+ 'configurations': {
+ 'Common_Base': {
+ 'msvs_configuration_attributes': {
+ 'CharacterSet': '0',
+ },
+ },
+ },
+ }],
+ ],
+ },
+ {
'target_name': 'libdart_withcore',
'type': 'static_library',
'dependencies': [
@@ -339,7 +370,8 @@
],
'sources': [
'gen_snapshot.cc',
- 'builtin.cc',
+ # Only looks up native functions in libdart_builtin, not libdart_io.
+ 'builtin_gen_snapshot.cc',
# Include generated source files.
'<(builtin_cc_file)',
'<(crypto_cc_file)',
@@ -421,6 +453,7 @@
'dependencies': [
'libdart_export',
'libdart_builtin',
+ 'libdart_io',
'generate_snapshot_file',
],
'include_dirs': [
@@ -453,6 +486,7 @@
'dependencies': [
'libdart_withcore',
'libdart_builtin',
+ 'libdart_io',
],
'include_dirs': [
'..',
@@ -497,6 +531,7 @@
'dependencies': [
'libdart_withcore',
'libdart_builtin',
+ 'libdart_io',
'generate_snapshot_test_dat_file',
],
'include_dirs': [
« no previous file with comments | « no previous file | runtime/bin/builtin.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698