Browser Plugin: Implement AutoSize

content/browser/renderer_host/render_view_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_view_host_impl.h"
 
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 910 matching lines @@
   // Allow BrowserPluginHostMsg_* sync messages to run on the UI thread.
   // Platform apps will not support windowed plugins so the deadlock cycle
   // browser -> plugin -> renderer -> browser referred in
   // BrowserMessageFilter::CheckCanDispatchOnUI() is not supposed to happen. If
   // we want to support windowed plugins, sync messages in BrowserPlugin might
   // need to be changed to async messages.
   // TODO(fsamuel): Disallow BrowserPluginHostMsg_* sync messages to run on UI
   // thread and make these messages async: http://crbug.com/149063.
   if (msg.type() != BrowserPluginHostMsg_HandleInputEvent::ID &&
       msg.type() != BrowserPluginHostMsg_ResizeGuest::ID &&
+      msg.type() != BrowserPluginHostMsg_SetAutoSize::ID &&

[jam, 2012/11/09 17:11:10]

anyway to avoid this sync IPC?

[Fady Samuel, 2012/11/09 17:41:10]

Yes, but not easily. We have a bug open related to this:

http://code.google.com/p/chromium/issues/detail?id=155915

The major issue is we need to share a buffer between two processes and we need
to make sure that both processes are aware of the new buffer prior to using it.
Using a SYNC IPC is the easy way to do this.

Coordinating this via async messages is certainly possible, but quite a bit
harder to get right.

[Fady Samuel, 2012/11/09 18:02:53]

As per offline discussion, this is a hard, general problem that needs to be
fixed for resize (auto or otherwise). We will address this for M25, in a
separate patch.

       !BrowserMessageFilter::CheckCanDispatchOnUI(msg, this))
     return true;
 
   // Filter out most IPC messages if this renderer is swapped out.
   // We still want to handle certain ACKs to keep our state consistent.
   if (is_swapped_out_) {
     if (!SwappedOutMessages::CanHandleWhileSwappedOut(msg)) {
       // If this is a synchronous message and we decided not to handle it,
       // we must send an error reply, or else the renderer will be stuck
       // and won't respond to future requests.
@@ skipping 1089 matching lines @@
   is_waiting_for_beforeunload_ack_ = false;
   is_waiting_for_unload_ack_ = false;
   has_timed_out_on_unload_ = false;
 }
 
 void RenderViewHostImpl::ClearPowerSaveBlockers() {
   STLDeleteValues(&power_save_blockers_);
 }
 
 }  // namespace content