Issue 11360082: Pass Isolate to MakeWeak(), IsWeak(), and AddObjectGroup().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11360082: Pass Isolate to MakeWeak(), IsWeak(), and AddObjectGroup(). (Closed)

Created:
8 years, 1 month ago by haraken

Modified:
8 years ago

Reviewers:
Michael Starzinger, danno

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

Pass Isolate to MakeWeak(), IsWeak(), and AddObjectGroup(). BUG= TEST=cctest/test-api/ApiObjectGroupsCycle Committed: http://code.google.com/p/v8/source/detail?r=13139

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -5 lines)			Patch
M	include/v8.h	View	6 chunks	+30 lines, -0 lines	0 comments	Download
M	src/api.cc	View	4 chunks	+32 lines, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	3 chunks	+30 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

haraken

These three APIs are in a hot call path of DOM object lifetime. Would you ...

8 years, 1 month ago (2012-11-05 14:59:19 UTC) #2

Michael Starzinger

8 years ago (2012-12-04 17:45:23 UTC) #3

LGTM. I'll rebase this to Sven's inlining changes and land this for you.