Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2176)

Unified Diff: tools/test.dart

Issue 11360028: Only start http server for browser tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/test.dart
diff --git a/tools/test.dart b/tools/test.dart
index fa057924decfd0652608332dfd85a5336924d9ec..2e4990d2a7cfcbe4f18248b6d9d157ad180c7eed 100755
--- a/tools/test.dart
+++ b/tools/test.dart
@@ -127,7 +127,13 @@ main() {
// Start global http server that serves the entire dart repo.
// The http server is available on localhost:9876 for any
// test that needs to load resources from the repo over http.
- if (!listTests) startHttpServer('127.0.0.1', 9876);
+ if (!listTests) {
+ // Only start the server if we are running browser tests.
+ var runningBrowserTests = configurations.some((config) {
+ return TestUtils.isBrowserRuntime(config['runtime']);
+ });
+ if (runningBrowserTests) startHttpServer('127.0.0.1', 9876);
+ }
// Start process queue.
new ProcessQueue(maxProcesses,
@@ -135,9 +141,7 @@ main() {
startTime,
printTiming,
enqueueConfiguration,
- () {
- if (!listTests) terminateHttpServer();
- },
+ () => terminateHttpServer(),
ricow1 2012/11/01 09:48:55 don't you still need to wrap this and only do it i
Mads Ager (google) 2012/11/01 10:12:57 I already did that. Have a look at http_server.dar
verbose,
listTests);
}
« no previous file with comments | « tools/ddbg.dart ('k') | tools/test-runtime.dart » ('j') | tools/test-runtime.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698