Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 11360010: cc: Pass gfx::Size type to FontAtlas drawText() function. (Closed)

Created:
8 years, 1 month ago by tfarina
Modified:
8 years, 1 month ago
Reviewers:
danakj, jamesr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Pass gfx::Size type to FontAtlas drawText() function. BUG=147395 TEST=cc_unittests R=danakj@chromium.org, enne@chromium.org, jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165276

Patch Set 1 : #

Total comments: 2

Patch Set 2 : implicit conversion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M cc/font_atlas.h View 2 chunks +3 lines, -4 lines 0 comments Download
M cc/font_atlas.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M cc/heads_up_display_layer_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
Hi Dana, could you review this to me?
8 years, 1 month ago (2012-10-31 16:05:43 UTC) #1
tfarina
+Adrienne and James for OWNERS approval.
8 years, 1 month ago (2012-10-31 16:16:21 UTC) #2
danakj
http://codereview.chromium.org/11360010/diff/4001/cc/heads_up_display_layer_impl.cc File cc/heads_up_display_layer_impl.cc (right): http://codereview.chromium.org/11360010/diff/4001/cc/heads_up_display_layer_impl.cc#newcode161 cc/heads_up_display_layer_impl.cc:161: m_fontAtlas->drawText(canvas, createPaint(), layerTree, gfx::Point(2, platformLayerTreeTop), clip_bounds); Shouldn't need this ...
8 years, 1 month ago (2012-10-31 16:29:30 UTC) #3
tfarina
http://codereview.chromium.org/11360010/diff/4001/cc/heads_up_display_layer_impl.cc File cc/heads_up_display_layer_impl.cc (right): http://codereview.chromium.org/11360010/diff/4001/cc/heads_up_display_layer_impl.cc#newcode161 cc/heads_up_display_layer_impl.cc:161: m_fontAtlas->drawText(canvas, createPaint(), layerTree, gfx::Point(2, platformLayerTreeTop), clip_bounds); On 2012/10/31 16:29:30, ...
8 years, 1 month ago (2012-10-31 16:32:23 UTC) #4
danakj
lgtm
8 years, 1 month ago (2012-10-31 16:51:47 UTC) #5
enne (OOO)
8 years, 1 month ago (2012-10-31 20:37:31 UTC) #6
lgtm2

Powered by Google App Engine
This is Rietveld 408576698