Issue 11360002: A Speculative Revert for 164939 - Use tcmalloc's debugallocation for Debug builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11360002: A Speculative Revert for 164939 - Use tcmalloc's debugallocation for Debug builds (Closed)

Created:
8 years, 1 month ago by Hironori Bono

Modified:
8 years, 1 month ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, erikwright+watch_chromium.org, dmikurube+memory_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

A Speculative Revert for 164939 - Use tcmalloc's debugallocation for Debug builds to catch memory problems early, easily, and cleanly. Because of gyp limitations, this can't be now controlled by a flag. BUG=30715 TEST=none Review URL: https://codereview.chromium.org/11266019 TBR=phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165096

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -31 lines)			Patch
M	base/allocator/allocator.gyp	View	6 chunks	+18 lines, -21 lines	0 comments	Download
M	base/allocator/allocator_shim.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	base/allocator/debugallocation_shim.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	build/common.gypi	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Hironori Bono

Greetings, Sorry for reverting your change. Unfortunately, PrerenderBrowserTests and File/MediaTests have been failing on the ...

8 years, 1 month ago (2012-10-31 03:36:45 UTC) #2

Hironori Bono

Greetings, It seems the "Linux Tests (dbg)(1)" bot cycled green after reverting your r164939. (I ...

8 years, 1 month ago (2012-10-31 06:59:10 UTC) #3

Paweł Hajdan Jr.

8 years, 1 month ago (2012-11-01 17:53:17 UTC) #4

Rubber stamp LGTM.

I'll reland soon, probably during my sheriff duty. I have few other things to
fix anyway.