Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2378)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1135923004: Observe onDeviceListChanged in network_list.js (Closed)

Created:
5 years, 7 months ago by stevenjb
Modified:
5 years, 7 months ago
Reviewers:
Greg Levin, michaelpg
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Observe onDeviceListChanged in network_list.js BUG=486231 Committed: https://crrev.com/db0b3e9c1b282f340e994f1e87fac5cd68057012 Cr-Commit-Position: refs/heads/master@{#329531}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/options/chromeos/network_list.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
stevenjb
We need to observe onDeviceStateList changed also to catch disable/enable changes.
5 years, 7 months ago (2015-05-11 03:13:47 UTC) #2
Greg Levin
lgtm
5 years, 7 months ago (2015-05-12 15:39:23 UTC) #3
michaelpg
lgtm
5 years, 7 months ago (2015-05-12 16:06:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135923004/20001
5 years, 7 months ago (2015-05-12 22:59:50 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 23:53:29 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 23:54:23 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/db0b3e9c1b282f340e994f1e87fac5cd68057012
Cr-Commit-Position: refs/heads/master@{#329531}

Powered by Google App Engine
This is Rietveld 408576698