Configure system-level Chrome settings (i.e. install its shortcuts) immediately following self-dest…

chrome/installer/setup/uninstall.cc

Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index a8459b99bd412c31140fb274cd82a380c54a571a..32d508d24fe5dadcdb5c886f53d74b3002c5dfb5 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -1270,6 +1270,18 @@ InstallStatus UninstallProduct(const InstallationState& original_state,
   if (!backup_state_file.empty())
     file_util::Delete(backup_state_file, false);
 
+  // Upon uninstalling user-level Chrome, install shortcuts to the system-level
+  // Chrome if it exists (in most such cases the user-level uninstall is a
+  // self-destruction).
+  if (product.is_chrome() && !installer_state.system_install()) {
+    const ProductState* system_level_product_state =
+        original_state.GetProductState(true, browser_dist->GetType());
+    if (system_level_product_state) {
+      FilePath system_chrome_path(GetChromeInstallPath(true, browser_dist));
+      HandleActiveSetupForBrowser(system_chrome_path, product, true);

[grt (UTC plus 2), 2012/11/16 04:32:32]

this will do active setup for whatever version of user-level chrome is being
uninstalled rather than the version of chrome installed at system-level.  this
seems fragile.  is this intended?

[gab, 2012/11/16 04:51:20]

True, the other option is to trigger the system-level's active setup command;
this is what I was going to do originally, but somehow the other setup wasn't
dying early and I couldn't figure out why, so I went the simple route instead in
this CL; now that I think about it and have played a little bit more with
LaunchProcess, I think it's because I wasn't launching the other setup out of
job and this setup would terminate almost immediately after and bring the other
one down with it (does that even make sense?).

For now this only installs shortcuts so it's fine, but I agree that it could
diverge over time.

+    }
+  }
+
   return ret;
 }