Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 11359218: [NaCl Addin] Add new property for setting name of index page. (Closed)

Created:
8 years, 1 month ago by Sam Clegg
Modified:
8 years, 1 month ago
Reviewers:
noelallen1, binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[NaCl Addin] Add new property for setting name of index page. As a result of this change we no longer need to ship the .user file for the hello_world_gles example, which is good. Also, add missing index_pnacl.html. BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1467

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -32 lines) Patch
M .gitignore View 2 chunks +4 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/ImportAfter/NaCl.override.props View 1 chunk +2 lines, -2 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Props/nacl_general.xml View 1 chunk +6 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Props/nacl_general_ps.xml View 1 chunk +6 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/NaCl64/Microsoft.Cpp.NaCl64.default.props View 1 chunk +1 line, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/ImportAfter/PPAPI.override.props View 1 chunk +2 lines, -2 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/Props/ppapi_general.xml.patch View 1 chunk +7 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl/hello_nacl.vcxproj View 2 chunks +16 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/hello_world_gles.vcxproj View 1 chunk +24 lines, -0 lines 2 comments Download
D visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/hello_world_gles.vcxproj.user View 1 chunk +0 lines, -27 lines 0 comments Download
A + visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/index_pnacl.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Sam Clegg
8 years, 1 month ago (2012-11-15 00:23:46 UTC) #1
binji
lgtm http://codereview.chromium.org/11359218/diff/1/visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/hello_world_gles.vcxproj File visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/hello_world_gles.vcxproj (right): http://codereview.chromium.org/11359218/diff/1/visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/hello_world_gles.vcxproj#newcode44 visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/hello_world_gles.vcxproj:44: <NaClIndexHTML>index_newlib.html</NaClIndexHTML> it looks like the .user file was ...
8 years, 1 month ago (2012-11-15 00:34:28 UTC) #2
Sam Clegg
8 years, 1 month ago (2012-11-15 00:56:26 UTC) #3
http://codereview.chromium.org/11359218/diff/1/visual_studio/NativeClientVSAd...
File
visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/hello_world_gles.vcxproj
(right):

http://codereview.chromium.org/11359218/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/hello_world_gles.vcxproj:44:
<NaClIndexHTML>index_newlib.html</NaClIndexHTML>
On 2012/11/15 00:34:28, binji wrote:
> it looks like the .user file was using the toolchain name. Is that not
necessary
> here?

Unfortunately I can't use the toolchain name in the name of the html file due to
the ordering of the VS project file.

Both the toolchain and the html file name need to be set early on before the
defaults.  This means they are in the same section, which means we cannot
guarantee that one is set first :(

For most users the index will just be the default "index.html" so I'm hoping
that this example is very rare case.

Powered by Google App Engine
This is Rietveld 408576698