Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: sql/connection_unittest.cc

Issue 11359217: Move scoped_temp_dir from base to base/files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « rlz/test/rlz_test_helpers.h ('k') | sql/sqlite_features_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_util.h" 5 #include "base/file_util.h"
6 #include "base/scoped_temp_dir.h" 6 #include "base/files/scoped_temp_dir.h"
7 #include "sql/connection.h" 7 #include "sql/connection.h"
8 #include "sql/meta_table.h"
8 #include "sql/statement.h" 9 #include "sql/statement.h"
9 #include "sql/meta_table.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 #include "third_party/sqlite/sqlite3.h" 11 #include "third_party/sqlite/sqlite3.h"
12 12
13 class SQLConnectionTest : public testing::Test { 13 class SQLConnectionTest : public testing::Test {
14 public: 14 public:
15 SQLConnectionTest() {} 15 SQLConnectionTest() {}
16 16
17 void SetUp() { 17 void SetUp() {
18 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); 18 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
19 ASSERT_TRUE(db_.Open(db_path())); 19 ASSERT_TRUE(db_.Open(db_path()));
20 } 20 }
21 21
22 void TearDown() { 22 void TearDown() {
23 db_.Close(); 23 db_.Close();
24 } 24 }
25 25
26 sql::Connection& db() { return db_; } 26 sql::Connection& db() { return db_; }
27 27
28 FilePath db_path() { 28 FilePath db_path() {
29 return temp_dir_.path().AppendASCII("SQLConnectionTest.db"); 29 return temp_dir_.path().AppendASCII("SQLConnectionTest.db");
30 } 30 }
31 31
32 private: 32 private:
33 ScopedTempDir temp_dir_; 33 base::ScopedTempDir temp_dir_;
34 sql::Connection db_; 34 sql::Connection db_;
35 }; 35 };
36 36
37 TEST_F(SQLConnectionTest, Execute) { 37 TEST_F(SQLConnectionTest, Execute) {
38 // Valid statement should return true. 38 // Valid statement should return true.
39 ASSERT_TRUE(db().Execute("CREATE TABLE foo (a, b)")); 39 ASSERT_TRUE(db().Execute("CREATE TABLE foo (a, b)"));
40 EXPECT_EQ(SQLITE_OK, db().GetErrorCode()); 40 EXPECT_EQ(SQLITE_OK, db().GetErrorCode());
41 41
42 // Invalid statement should fail. 42 // Invalid statement should fail.
43 ASSERT_EQ(SQLITE_ERROR, 43 ASSERT_EQ(SQLITE_ERROR,
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 // Otherwise, sqlite3 doesn't find the correct directory to store 288 // Otherwise, sqlite3 doesn't find the correct directory to store
289 // temporary files and will report the error 'unable to open 289 // temporary files and will report the error 'unable to open
290 // database file'. 290 // database file'.
291 ASSERT_TRUE(meta_table.Init(&db(), 4, 4)); 291 ASSERT_TRUE(meta_table.Init(&db(), 4, 4));
292 } 292 }
293 #endif 293 #endif
294 294
295 // TODO(shess): Spin up a background thread to hold other_db, to more 295 // TODO(shess): Spin up a background thread to hold other_db, to more
296 // closely match real life. That would also allow testing 296 // closely match real life. That would also allow testing
297 // RazeWithTimeout(). 297 // RazeWithTimeout().
OLDNEW
« no previous file with comments | « rlz/test/rlz_test_helpers.h ('k') | sql/sqlite_features_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698