Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Side by Side Diff: chrome/common/mac/app_mode_chrome_locator_unittest.mm

Issue 11359217: Move scoped_temp_dir from base to base/files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/common/mac/app_mode_chrome_locator.h" 5 #import "chrome/common/mac/app_mode_chrome_locator.h"
6 6
7 #include <CoreFoundation/CoreFoundation.h> 7 #include <CoreFoundation/CoreFoundation.h>
8 8
9 #include "base/file_path.h" 9 #include "base/file_path.h"
10 #include "base/file_util.h" 10 #include "base/file_util.h"
11 #include "base/files/scoped_temp_dir.h"
11 #include "base/path_service.h" 12 #include "base/path_service.h"
12 #include "base/scoped_temp_dir.h"
13 #include "chrome/common/chrome_constants.h" 13 #include "chrome/common/chrome_constants.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 namespace { 16 namespace {
17 17
18 // Return the path to the Chrome/Chromium app bundle compiled along with the 18 // Return the path to the Chrome/Chromium app bundle compiled along with the
19 // test executable. 19 // test executable.
20 void GetChromeBundlePath(FilePath* chrome_bundle) { 20 void GetChromeBundlePath(FilePath* chrome_bundle) {
21 FilePath path; 21 FilePath path;
22 PathService::Get(base::DIR_EXE, &path); 22 PathService::Get(base::DIR_EXE, &path);
(...skipping 10 matching lines...) Expand all
33 app_mode::FindBundleById(@"com.apple.finder", &finder_bundle_path)); 33 app_mode::FindBundleById(@"com.apple.finder", &finder_bundle_path));
34 EXPECT_TRUE(file_util::DirectoryExists(finder_bundle_path)); 34 EXPECT_TRUE(file_util::DirectoryExists(finder_bundle_path));
35 } 35 }
36 36
37 TEST(ChromeLocatorTest, FindNonExistentBundle) { 37 TEST(ChromeLocatorTest, FindNonExistentBundle) {
38 FilePath dummy; 38 FilePath dummy;
39 EXPECT_FALSE(app_mode::FindBundleById(@"this.doesnt.exist", &dummy)); 39 EXPECT_FALSE(app_mode::FindBundleById(@"this.doesnt.exist", &dummy));
40 } 40 }
41 41
42 TEST(ChromeLocatorTest, GetNonExistentBundleInfo) { 42 TEST(ChromeLocatorTest, GetNonExistentBundleInfo) {
43 ScopedTempDir temp_dir; 43 base::ScopedTempDir temp_dir;
44 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); 44 ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
45 45
46 string16 raw_version; 46 string16 raw_version;
47 FilePath version_path; 47 FilePath version_path;
48 FilePath framework_path; 48 FilePath framework_path;
49 EXPECT_FALSE(app_mode::GetChromeBundleInfo(temp_dir.path(), 49 EXPECT_FALSE(app_mode::GetChromeBundleInfo(temp_dir.path(),
50 &raw_version, &version_path, &framework_path)); 50 &raw_version, &version_path, &framework_path));
51 } 51 }
52 52
53 TEST(ChromeLocatorTest, GetChromeBundleInfo) { 53 TEST(ChromeLocatorTest, GetChromeBundleInfo) {
54 using app_mode::GetChromeBundleInfo; 54 using app_mode::GetChromeBundleInfo;
55 55
56 FilePath chrome_bundle_path; 56 FilePath chrome_bundle_path;
57 GetChromeBundlePath(&chrome_bundle_path); 57 GetChromeBundlePath(&chrome_bundle_path);
58 ASSERT_TRUE(file_util::DirectoryExists(chrome_bundle_path)); 58 ASSERT_TRUE(file_util::DirectoryExists(chrome_bundle_path));
59 59
60 string16 raw_version; 60 string16 raw_version;
61 FilePath version_path; 61 FilePath version_path;
62 FilePath framework_path; 62 FilePath framework_path;
63 EXPECT_TRUE(GetChromeBundleInfo(chrome_bundle_path, 63 EXPECT_TRUE(GetChromeBundleInfo(chrome_bundle_path,
64 &raw_version, &version_path, &framework_path)); 64 &raw_version, &version_path, &framework_path));
65 EXPECT_GT(raw_version.size(), 0U); 65 EXPECT_GT(raw_version.size(), 0U);
66 EXPECT_TRUE(file_util::DirectoryExists(version_path)); 66 EXPECT_TRUE(file_util::DirectoryExists(version_path));
67 EXPECT_TRUE(file_util::PathExists(framework_path)); 67 EXPECT_TRUE(file_util::PathExists(framework_path));
68 } 68 }
OLDNEW
« no previous file with comments | « chrome/common/json_value_serializer_unittest.cc ('k') | chrome/common/service_process_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698