Implement the Instant extended API startMargin, endMargin, and rtl properties and the onmarginchang…

chrome/browser/ui/browser_instant_controller.h

Index: chrome/browser/ui/browser_instant_controller.h
diff --git a/chrome/browser/ui/browser_instant_controller.h b/chrome/browser/ui/browser_instant_controller.h
index 0cbaa8e7e3f2248a24bdeeedf659efaa4368533b..59dce3468bdba75d187421bcb722d5ad915ad108 100644
--- a/chrome/browser/ui/browser_instant_controller.h
+++ b/chrome/browser/ui/browser_instant_controller.h
@@ -84,6 +84,9 @@ class BrowserInstantController : public content::NotificationObserver,
   // Invoked by |instant_| to update theme information for preview.
   void UpdateThemeInfoForPreview();
 
+  // Sets the start and end margins of the omnibox text area.
+  void SetMarginSize(int start, int end);

[sky, 2012/12/12 03:46:55]

This isn't margins but actual position, right? Wouldn't a better name be
SetOmniboxViewBounds(int leading, int trailing)?

[melevin, 2012/12/12 19:32:43]

All of these functions refer to margins because they are implementing the
"startMargin" and "endMargin" properties of the SearchBox API:
https://docs.google.com/a/google.com/document/d/11aOAG80JauTJBsblI2h7RF6xa5uc...

I also think its a bit misleading to call a "SetOmniboxViewBounds" with anything
other than a rect that has the actual OmniboxView bounds (which is not what we
want either).

[sky, 2012/12/12 21:12:46]

I agree that bounds implies a rectangle. That is easily fixed by passing in an
actual rectangle. I still think margin is a bad name here and in the search box
API.

+
  private:
   // Sets the value of |instant_| based on value from profile. Invoked
   // on pref change.