chrome/browser/ui/omnibox/omnibox_edit_model.h - Issue 11359198: Implement the Instant extended API startMargin, endMargin, and rtl properties and the onmarginchang…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_edit_model.h

Issue 11359198: Implement the Instant extended API startMargin, endMargin, and rtl properties and the onmarginchang… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase after r171018 Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/instant/instant_controller.cc ('K') | « chrome/browser/instant/instant_loader.cc ('k') | chrome/browser/ui/omnibox/omnibox_edit_model.cc » ('j') | chrome/browser/ui/omnibox/omnibox_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/omnibox/omnibox_edit_model.h

diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.h b/chrome/browser/ui/omnibox/omnibox_edit_model.h

index 6caf62f542932a94b4d3cbe564454c88cc6574c4..54b25d70839944e30679289eb17f5182fb53c7ac 100644

--- a/chrome/browser/ui/omnibox/omnibox_edit_model.h

+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.h

@@ -273,8 +273,11 @@ class OmniboxEditModel : public AutocompleteControllerDelegate {

bool just_deleted_text,

bool allow_keyword_ui_change);

- // Invoked when the popup is going to change its bounds to |bounds|.

- void PopupBoundsChangedTo(const gfx::Rect& bounds);

+ // Invoked when the popup has changed its bounds to |bounds|.

sky 2012/12/04 23:06:36 You need to document the coordinate system of both

melevin 2012/12/06 23:13:00 Done.

+ void OnPopupBoundsChanged(const gfx::Rect& bounds);

+ // Invoked when the omnibox has changed its bounds to |bounds|.

+ void OnOmniboxBoundsChanged(const gfx::Rect& omnibox_bounds);

private:

enum PasteState {