Implement the Instant extended API startMargin, endMargin, and rtl properties and the onmarginchang…

chrome/browser/instant/instant_controller.h

Index: chrome/browser/instant/instant_controller.h
diff --git a/chrome/browser/instant/instant_controller.h b/chrome/browser/instant/instant_controller.h
index 941dd15b96190124a9b9567ab4e62828fa91f030..d1d6e7c9049a6f515eebec045230c1cdba42159f 100644
--- a/chrome/browser/instant/instant_controller.h
+++ b/chrome/browser/instant/instant_controller.h
@@ -62,8 +62,11 @@ class InstantController {
               bool user_input_in_progress,
               bool omnibox_popup_is_open);
 
-  // Sets the bounds of the omnibox dropdown, in screen coordinates.
-  void SetOmniboxBounds(const gfx::Rect& bounds);
+  // Sets the bounds of the omnibox popup, in screen coordinates.
+  void SetPopupBounds(const gfx::Rect& bounds);
+
+  // Sets the widths of the start and end margins of the Instant page.
+  void SetMarginSize(int start, int end);
 
   // Send autocomplete results from |providers| to the preview page.
   void HandleAutocompleteResults(
@@ -182,8 +185,8 @@ class InstantController {
                   int height,
                   InstantSizeUnits units);
 
-  // Send the omnibox dropdown bounds to the page.
-  void SendBoundsToPage();
+  // Send the omnibox popup bounds to the page.
+  void SendPopupBoundsToPage();
 
   // If |template_url| is a valid TemplateURL for use with Instant, fills in
   // |instant_url| and returns true; returns false otherwise.
@@ -242,9 +245,21 @@ class InstantController {
   // Current omnibox bounds.
   gfx::Rect omnibox_bounds_;
 
-  // Last bounds passed to the page.
+  // Last omnibox bounds passed to the page.
   gfx::Rect last_omnibox_bounds_;

[sreeram, 2012/12/05 00:14:46]

Shouldn't these (omnibox_bounds_ and last_omnibox_bounds_) be removed now?

[melevin, 2012/12/06 23:13:00]

Yup, done.

 
+  // Current omnibox popup bounds.
+  gfx::Rect popup_bounds_;
+
+  // Last popup bounds passed to the page.
+  gfx::Rect last_popup_bounds_;
+
+  // Size of the start-edge omnibox text area margin.
+  int start_margin_;
+
+  // Size of the end-edge omnibox text area margin.
+  int end_margin_;
+
   // Timer used to update the bounds of the omnibox.

[sreeram, 2012/12/05 00:14:46]

"... bounds of the omnibox popup."

[melevin, 2012/12/06 23:13:00]

Done.

   base::OneShotTimer<InstantController> update_bounds_timer_;