Implement the Instant extended API startMargin, endMargin, and rtl properties and the onmarginchang…

chrome/browser/ui/views/omnibox/omnibox_view_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 423 matching lines @@
   state->name = l10n_util::GetStringUTF16(IDS_ACCNAME_LOCATION);
 }
 
 std::string OmniboxViewViews::GetClassName() const {
   return kViewClassName;
 }
 
 void OmniboxViewViews::OnBoundsChanged(const gfx::Rect& previous_bounds) {
   if (popup_view_->IsOpen())
     popup_view_->UpdatePopupAppearance();
+
+  // Pass the location bar's bounds to the edit model because the OmniboxView
+  // does not fill the entire box when gray text is showing. We also pass the
+  // parent view's bounds so that the end margin can be calculated.

[sreeram, 2012/11/29 19:22:49]

What does "gray text" have to do with this? I thought the page needed the
omnibox bounds so that it could size its suggestions list accordingly.

[melevin, 2012/11/30 23:37:09]

Yes, that's what we need it for. But we can't use the dimensions of the
OmniboxView for that. When gray text is showing that view does not fill the
entire location bar.

+  model()->OnOmniboxBoundsChanged(location_bar_view_->GetBoundsInScreen(),
+      location_bar_view_->parent()->GetBoundsInScreen());
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // OmniboxViewViews, AutocopmleteEditView implementation:
 
 void OmniboxViewViews::SaveStateToTab(WebContents* tab) {
   DCHECK(tab);
 
   // We don't want to keep the IME status, so force quit the current
   // session here.  It may affect the selection status, so order is
@@ skipping 479 matching lines @@
   if (!text.empty()) {
     // Record this paste, so we can do different behavior.
     model()->on_paste();
     // Force a Paste operation to trigger the text_changed code in
     // OnAfterPossibleChange(), even if identical contents are pasted into the
     // text box.
     text_before_change_.clear();
     textfield_->ReplaceSelection(text);
   }
 }