Implement the Instant extended API startMargin, endMargin, and rtl properties and the onmarginchang…

chrome/browser/ui/views/omnibox/omnibox_view_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 424 matching lines @@
   state->name = l10n_util::GetStringUTF16(IDS_ACCNAME_LOCATION);
 }
 
 std::string OmniboxViewViews::GetClassName() const {
   return kViewClassName;
 }
 
 void OmniboxViewViews::OnBoundsChanged(const gfx::Rect& previous_bounds) {
   if (popup_view_->IsOpen())
     popup_view_->UpdatePopupAppearance();
+
+  // Pass the location bar's bounds to the edit model. The OmniboxView bounds
+  // cannot be used here because the OmniboxView does not fill the entire box
+  // when gray text is showing.
+  model()->OnOmniboxBoundsChanged(location_bar_view_->GetBoundsInScreen());

[sky, 2012/12/04 23:06:36]

The locationbarview might contain a bunch of other views, eg the star, ev
stuff... Are you sure you want to include them? Also, if you care about the
bounds of the lbv, why is this here and not in the lbv?

[melevin, 2012/12/06 23:13:00]

Yes, we want the outer bounds of the location box.
Ok, I've moved the code to respond to a change in the bounds of the
LocationBarView.

 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // OmniboxViewViews, AutocopmleteEditView implementation:
 
 void OmniboxViewViews::SaveStateToTab(WebContents* tab) {
   DCHECK(tab);
 
   // We don't want to keep the IME status, so force quit the current
   // session here.  It may affect the selection status, so order is
@@ skipping 219 matching lines @@
 
 int OmniboxViewViews::TextWidth() const {
   // TODO(oshima): add horizontal margin.
   return textfield_->font().GetStringWidth(textfield_->text());
 }
 
 bool OmniboxViewViews::IsImeComposing() const {
   return false;
 }
 
+gfx::Rect OmniboxViewViews::GetContainerBounds() const {
+  return location_bar_view_->parent()->GetBoundsInScreen();
+}
+
 int OmniboxViewViews::GetMaxEditWidth(int entry_width) const {
   return entry_width;
 }
 
 views::View* OmniboxViewViews::AddToView(views::View* parent) {
   parent->AddChildView(this);
   AddChildView(textfield_);
   return this;
 }
 
@@ skipping 240 matching lines @@
   if (!text.empty()) {
     // Record this paste, so we can do different behavior.
     model()->on_paste();
     // Force a Paste operation to trigger the text_changed code in
     // OnAfterPossibleChange(), even if identical contents are pasted into the
     // text box.
     text_before_change_.clear();
     textfield_->ReplaceSelection(text);
   }
 }