Implement the Instant extended API startMargin, endMargin, and rtl properties and the onmarginchang…

chrome/browser/ui/omnibox/omnibox_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines the interface class OmniboxView.  Each toolkit will
 // implement the edit view differently, so that code is inherently platform
 // specific.  However, the OmniboxEditModel needs to do some communication with
 // the view.  Since the model is shared between platforms, we need to define an
 // interface that all view implementations will share.
 
@@ skipping 182 matching lines @@
   // Returns the current instant suggestion text.
   virtual string16 GetInstantSuggestion() const = 0;
 
   // Returns the width in pixels needed to display the current text. The
   // returned value includes margins.
   virtual int TextWidth() const = 0;
 
   // Returns true if the user is composing something in an IME.
   virtual bool IsImeComposing() const = 0;
 
+  // Get the bounds of the widget containing the omnibox.
+  virtual gfx::Rect GetContainerBounds() const = 0;

[sky, 2012/12/04 23:06:36]

It's not clear what you mean by 'container' here, and your implementation isn't
really doing what the description says.

It seems you only use this in OmniboxEditModel::OnOmniboxBoundsChanged. Instead
of adding a new method make OnOmniboxBoundsChanged take the region you need
(this echoes my earlier comment).

[melevin, 2012/12/06 23:13:00]

I've removed both functions. The LocationBarView will now compute and pass the
margins directly to Instant.

+
 #if defined(TOOLKIT_VIEWS)
   virtual int GetMaxEditWidth(int entry_width) const = 0;
 
   // Adds the autocomplete edit view to view hierarchy and
   // returns the views::View of the edit view.
   virtual views::View* AddToView(views::View* parent) = 0;
 
   // Performs the drop of a drag and drop operation on the view.
   virtual int OnPerformDrop(const ui::DropTargetEvent& event) = 0;
 
@@ skipping 38 matching lines @@
   scoped_ptr<OmniboxEditModel> model_;
   OmniboxEditController* controller_;
   ToolbarModel* toolbar_model_;
 
   // The object that handles additional command functionality exposed on the
   // edit, such as invoking the keyword editor.
   CommandUpdater* command_updater_;
 };
 
 #endif  // CHROME_BROWSER_UI_OMNIBOX_OMNIBOX_VIEW_H_