Implement the Instant extended API startMargin, endMargin, and rtl properties and the onmarginchang…

chrome/browser/instant/instant_controller.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_INSTANT_INSTANT_CONTROLLER_H_
 #define CHROME_BROWSER_INSTANT_INSTANT_CONTROLLER_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 44 matching lines @@
   // update is accepted (i.e., if |match| is a search rather than a URL).
   bool Update(const AutocompleteMatch& match,
               const string16& user_text,
               const string16& full_text,
               size_t selection_start,
               size_t selection_end,
               bool verbatim,
               bool user_input_in_progress,
               bool omnibox_popup_is_open);
 
-  // Sets the bounds of the omnibox dropdown, in screen coordinates.
-  void SetOmniboxBounds(const gfx::Rect& bounds);
+  // Sets the bounds of the omnibox popup, in screen coordinates.
+  void SetPopupBounds(const gfx::Rect& bounds);
+
+  // Sets the widths of the start and end margins of the Instant page.
+  void SetMarginSize(int start, int end);
 
   // Send autocomplete results from |providers| to the preview page.
   void HandleAutocompleteResults(
       const std::vector<AutocompleteProvider*>& providers);
 
   // Called when the user presses up or down. |count| is a repeat count,
   // negative for moving up, positive for moving down. Returns true if Instant
   // handled the key press.
   bool OnUpOrDownKeyPressed(int count);
 
@@ skipping 98 matching lines @@
   // Like HideLoader(), but doesn't call OnStaleLoader(). Use HideLoader()
   // unless you are going to call loader_.reset() yourself subsequently.
   void HideInternal();
 
   // Counterpart to HideLoader(). Asks the |browser_| to display the preview
   // with the given |height|.
   void ShowLoader(InstantShownReason reason,
                   int height,
                   InstantSizeUnits units);
 
-  // Send the omnibox dropdown bounds to the page.
-  void SendBoundsToPage();
+  // Send the omnibox popup bounds to the page.
+  void SendPopupBoundsToPage();
 
   // If |template_url| is a valid TemplateURL for use with Instant, fills in
   // |instant_url| and returns true; returns false otherwise.
   // Note: If the command-line switch kInstantURL is set, this method uses its
   // value for |instant_url| and returns true without examining |template_url|.
   bool GetInstantURL(const TemplateURL* template_url,
                      std::string* instant_url) const;
 
   chrome::BrowserInstantController* const browser_;
 
@@ skipping 38 matching lines @@
 
   // True if the omnibox is focused, false otherwise.
   bool is_omnibox_focused_;
 
   // The search model mode for the active tab.
   chrome::search::Mode search_mode_;
 
   // Current omnibox bounds.
   gfx::Rect omnibox_bounds_;
 
-  // Last bounds passed to the page.
+  // Last omnibox bounds passed to the page.
   gfx::Rect last_omnibox_bounds_;

[sreeram, 2012/12/05 00:14:46]

Shouldn't these (omnibox_bounds_ and last_omnibox_bounds_) be removed now?

[melevin, 2012/12/06 23:13:00]

Yup, done.

 
+  // Current omnibox popup bounds.
+  gfx::Rect popup_bounds_;
+
+  // Last popup bounds passed to the page.
+  gfx::Rect last_popup_bounds_;
+
+  // Size of the start-edge omnibox text area margin.
+  int start_margin_;
+
+  // Size of the end-edge omnibox text area margin.
+  int end_margin_;
+
   // Timer used to update the bounds of the omnibox.

[sreeram, 2012/12/05 00:14:46]

"... bounds of the omnibox popup."

[melevin, 2012/12/06 23:13:00]

Done.

   base::OneShotTimer<InstantController> update_bounds_timer_;
 
   // Timer used to ensure that the Instant page does not get too stale.
   base::OneShotTimer<InstantController> stale_loader_timer_;
 
   // For each key K => value N, the map says that we found that the search
   // engine identified by Instant URL K didn't support the Instant API in each
   // of the last N times that we loaded it. If an Instant URL isn't present in
   // the map at all or has a value 0, it means that search engine supports the
   // Instant API (or we assume it does, since we haven't determined it doesn't).
@@ skipping 12 matching lines @@
 
   // Whether to allow the preview to show search suggestions. In general, the
   // preview is allowed to show search suggestions whenever |search_mode_| is
   // MODE_SEARCH_SUGGESTIONS, except in those cases where this is false.
   bool allow_preview_to_show_search_suggestions_;
 
   DISALLOW_COPY_AND_ASSIGN(InstantController);
 };
 
 #endif  // CHROME_BROWSER_INSTANT_INSTANT_CONTROLLER_H_