Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Unified Diff: content/renderer/media/render_audiosourceprovider.cc

Issue 11359196: Associate audio streams with their source/destination RenderView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Restored AudioDeviceFactory. Created new RendererAudioOutputDevice. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/render_audiosourceprovider.cc
diff --git a/content/renderer/media/render_audiosourceprovider.cc b/content/renderer/media/render_audiosourceprovider.cc
index 750db7fe0a47472c99bbdc50ff3ba7f612062da2..9fdcec705b66567ac5f2d6047747179a8d553ff8 100644
--- a/content/renderer/media/render_audiosourceprovider.cc
+++ b/content/renderer/media/render_audiosourceprovider.cc
@@ -11,6 +11,7 @@
#include "base/logging.h"
#include "content/renderer/media/audio_device_factory.h"
#include "content/renderer/media/audio_renderer_mixer_manager.h"
+#include "content/renderer/media/renderer_audio_output_device.h"
#include "content/renderer/render_thread_impl.h"
#include "media/base/audio_renderer_mixer_input.h"
#include "media/base/media_switches.h"
@@ -21,7 +22,7 @@ using WebKit::WebVector;
namespace content {
-RenderAudioSourceProvider::RenderAudioSourceProvider()
+RenderAudioSourceProvider::RenderAudioSourceProvider(int source_render_view_id)
: is_initialized_(false),
channels_(0),
sample_rate_(0),
@@ -44,8 +45,19 @@ RenderAudioSourceProvider::RenderAudioSourceProvider()
if (use_mixing) {
default_sink_ = RenderThreadImpl::current()->
GetAudioRendererMixerManager()->CreateInput();
+ // TODO(miu): Partition mixer instances per RenderView.
} else {
- default_sink_ = AudioDeviceFactory::NewOutputDevice();
+ scoped_refptr<RendererAudioOutputDevice> device =
+ AudioDeviceFactory::NewOutputDevice();
+ // The RenderView creating RenderAudioSourceProvider will be the source of
+ // the audio (WebMediaPlayer is always associated with a single frame).
+ //
+ // TODO(miu): Unfortunately, there is one use case where this is not true:
+ // JavaScript code can call new Audio() and pass the object around. The
+ // RenderAudioSourceProvider is not instantiated until the "src" attribute
+ // has been set.
+ device->SetSourceRenderView(source_render_view_id);
+ default_sink_ = device;
}
}

Powered by Google App Engine
This is Rietveld 408576698