content/renderer/media/webrtc_audio_capturer.h - Issue 11359196: Associate audio streams with their source/destination RenderView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_capturer.h

Issue 11359196: Associate audio streams with their source/destination RenderView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed Dale's comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/webrtc_audio_capturer.h

diff --git a/content/renderer/media/webrtc_audio_capturer.h b/content/renderer/media/webrtc_audio_capturer.h

index f01f8d0e27ca8a40ff2ff71f66a11af45aea4de3..5e60de38c0fe92689d79c91cffa724a39bfd3c83 100644

--- a/content/renderer/media/webrtc_audio_capturer.h

+++ b/content/renderer/media/webrtc_audio_capturer.h

@@ -40,7 +40,7 @@ class WebRtcAudioCapturer

// SetCapturerSource() is called if client on the source side desires to

// provide their own captured audio data. Client is responsible for calling

// Start() on its own source to have the ball rolling.

- void SetCapturerSource(media::AudioCapturerSource* source);

+ void SetCapturerSource(scoped_refptr<media::AudioCapturerSource> source);

scherkus (not reviewing) 2012/11/28 21:55:01 nit: we like to const-ref-ify the scoped_refptr<>

miu 2012/11/28 22:20:54 Me too! ;-) Somehow I missed it this time. Done

// Starts recording audio.

void Start();