Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Side by Side Diff: media/audio/audio_output_device.h

Issue 11359196: Associate audio streams with their source/destination RenderView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Andrew's review comments. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Audio rendering unit utilizing audio output stream provided by browser 5 // Audio rendering unit utilizing audio output stream provided by browser
6 // process through IPC. 6 // process through IPC.
7 // 7 //
8 // Relationship of classes. 8 // Relationship of classes.
9 // 9 //
10 // AudioOutputController AudioOutputDevice 10 // AudioOutputController AudioOutputDevice
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 // Methods called on IO thread ---------------------------------------------- 92 // Methods called on IO thread ----------------------------------------------
93 // AudioOutputIPCDelegate methods. 93 // AudioOutputIPCDelegate methods.
94 virtual void OnStateChanged(AudioOutputIPCDelegate::State state) OVERRIDE; 94 virtual void OnStateChanged(AudioOutputIPCDelegate::State state) OVERRIDE;
95 virtual void OnStreamCreated(base::SharedMemoryHandle handle, 95 virtual void OnStreamCreated(base::SharedMemoryHandle handle,
96 base::SyncSocket::Handle socket_handle, 96 base::SyncSocket::Handle socket_handle,
97 int length) OVERRIDE; 97 int length) OVERRIDE;
98 virtual void OnIPCClosed() OVERRIDE; 98 virtual void OnIPCClosed() OVERRIDE;
99 99
100 // Creates an uninitialized AudioOutputDevice. Clients must call Initialize() 100 // Creates an uninitialized AudioOutputDevice. Clients must call Initialize()
101 // before using. 101 // before using.
102 // TODO(tommi): When all dependencies on |content| have been removed
103 // from AudioOutputDevice, move this class over to media/audio.
104 AudioOutputDevice(AudioOutputIPC* ipc, 102 AudioOutputDevice(AudioOutputIPC* ipc,
105 const scoped_refptr<base::MessageLoopProxy>& io_loop); 103 const scoped_refptr<base::MessageLoopProxy>& io_loop);
106 104
105 // Returns the stream id used with the AudioOutputIPC interface.
106 int stream_id() const;
107
107 protected: 108 protected:
108 // Magic required by ref_counted.h to avoid any code deleting the object 109 // Magic required by ref_counted.h to avoid any code deleting the object
109 // accidentally while there are references to it. 110 // accidentally while there are references to it.
110 friend class base::RefCountedThreadSafe<AudioOutputDevice>; 111 friend class base::RefCountedThreadSafe<AudioOutputDevice>;
111 virtual ~AudioOutputDevice(); 112 virtual ~AudioOutputDevice();
112 113
113 private: 114 private:
115 enum State {
116 IPC_CLOSED, // No more IPCs can take place.
117 IDLE, // Not started.
118 CREATING_STREAM, // Waiting for OnStreamCreated() to be called back.
119 PAUSED, // Paused. OnStreamCreated() has been called. Can Play()/Stop().
120 PLAYING, // Playing back. Can Pause()/Stop().
121 };
122
114 // Methods called on IO thread ---------------------------------------------- 123 // Methods called on IO thread ----------------------------------------------
115 // The following methods are tasks posted on the IO thread that needs to 124 // The following methods are tasks posted on the IO thread that needs to
116 // be executed on that thread. They interact with AudioMessageFilter and 125 // be executed on that thread. They interact with AudioMessageFilter and
117 // sends IPC messages on that thread. 126 // sends IPC messages on that thread.
118 void CreateStreamOnIOThread(const AudioParameters& params, 127 void CreateStreamOnIOThread(const AudioParameters& params,
119 int input_channels); 128 int input_channels);
120 void PlayOnIOThread(); 129 void PlayOnIOThread();
121 void PauseOnIOThread(bool flush); 130 void PauseOnIOThread(bool flush);
122 void ShutDownOnIOThread(); 131 void ShutDownOnIOThread();
123 void SetVolumeOnIOThread(double volume); 132 void SetVolumeOnIOThread(double volume);
(...skipping 11 matching lines...) Expand all
135 RenderCallback* callback_; 144 RenderCallback* callback_;
136 145
137 // A pointer to the IPC layer that takes care of sending requests over to 146 // A pointer to the IPC layer that takes care of sending requests over to
138 // the AudioRendererHost. 147 // the AudioRendererHost.
139 AudioOutputIPC* ipc_; 148 AudioOutputIPC* ipc_;
140 149
141 // Our stream ID on the message filter. Only accessed on the IO thread. 150 // Our stream ID on the message filter. Only accessed on the IO thread.
142 // Must only be modified on the IO thread. 151 // Must only be modified on the IO thread.
143 int stream_id_; 152 int stream_id_;
144 153
154 // Current state (must only be accessed from the IO thread). See comments for
155 // State enum above.
156 State state_;
157
145 // State of Play() / Pause() calls before OnStreamCreated() is called. 158 // State of Play() / Pause() calls before OnStreamCreated() is called.
146 bool play_on_start_; 159 bool play_on_start_;
147 160
148 // Set to |true| when OnStreamCreated() is called.
149 // Set to |false| when ShutDownOnIOThread() is called.
150 // This is for use with play_on_start_ to track Play() / Pause() state.
151 // Must only be touched from the IO thread.
152 bool is_started_;
153
154 // Our audio thread callback class. See source file for details. 161 // Our audio thread callback class. See source file for details.
155 class AudioThreadCallback; 162 class AudioThreadCallback;
156 163
157 // In order to avoid a race between OnStreamCreated and Stop(), we use this 164 // In order to avoid a race between OnStreamCreated and Stop(), we use this
158 // guard to control stopping and starting the audio thread. 165 // guard to control stopping and starting the audio thread.
159 base::Lock audio_thread_lock_; 166 base::Lock audio_thread_lock_;
160 AudioDeviceThread audio_thread_; 167 AudioDeviceThread audio_thread_;
161 scoped_ptr<AudioOutputDevice::AudioThreadCallback> audio_callback_; 168 scoped_ptr<AudioOutputDevice::AudioThreadCallback> audio_callback_;
162 169
163 // Temporary hack to ignore OnStreamCreated() due to the user calling Stop() 170 // Temporary hack to ignore OnStreamCreated() due to the user calling Stop()
164 // so we don't start the audio thread pointing to a potentially freed 171 // so we don't start the audio thread pointing to a potentially freed
165 // |callback_|. 172 // |callback_|.
166 // 173 //
167 // TODO(scherkus): Replace this by changing AudioRendererSink to either accept 174 // TODO(scherkus): Replace this by changing AudioRendererSink to either accept
168 // the callback via Start(). See http://crbug.com/151051 for details. 175 // the callback via Start(). See http://crbug.com/151051 for details.
169 bool stopping_hack_; 176 bool stopping_hack_;
170 177
171 DISALLOW_COPY_AND_ASSIGN(AudioOutputDevice); 178 DISALLOW_COPY_AND_ASSIGN(AudioOutputDevice);
172 }; 179 };
173 180
174 } // namespace media 181 } // namespace media
175 182
176 #endif // MEDIA_AUDIO_AUDIO_OUTPUT_DEVICE_H_ 183 #endif // MEDIA_AUDIO_AUDIO_OUTPUT_DEVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698