Issue 11359194: Revert 167255 - ui: Remove gfx::Size::ClampToNonNegative, prevent negative sizes always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11359194: Revert 167255 - ui: Remove gfx::Size::ClampToNonNegative, prevent negative sizes always. (Closed)

Created:
8 years, 1 month ago by shawnsingh

Modified:
8 years, 1 month ago

Reviewers:
danakj

CC:
chromium-reviews, Aaron Boodman, cc-bugs_chromium.org, jeremya+watch_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 167255 - ui: Remove gfx::Size::ClampToNonNegative, prevent negative sizes always. This was added with the intention of using Size as a vector, replacing use of IntSize. Since we have Vector2d now, negative sizes should not exist, so clamp them in set_width/set_height and the constructor. Not covered by tests, as we can't test DCHECKs. TBR=sky BUG=160158 Relanding: https://codereview.chromium.org/11365160/ Review URL: https://codereview.chromium.org/11410024 TBR=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167504

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -63 lines)			Patch
M	cc/draw_quad_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/app_window/app_window_api.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/extensions/shell_window.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/extensions/shell_window.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/base/gestures/gesture_sequence.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	ui/gfx/rect_f.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	ui/gfx/rect_unittest.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	ui/gfx/size.cc	View	2 chunks	+8 lines, -5 lines	0 comments	Download
M	ui/gfx/size_base.h	View	2 chunks	+13 lines, -4 lines	0 comments	Download
D	ui/gfx/size_base_impl.h	View	1 chunk	+0 lines, -37 lines	0 comments	Download
M	ui/gfx/size_f.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	ui/gfx/size_unittest.cc	View	3 chunks	+18 lines, -0 lines	0 comments	Download
M	ui/ui.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)