ui/views/view_unittest.cc - Issue 11359172: ui: Remove implicit flooring in skia rect conversion methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/view_unittest.cc

Issue 11359172: ui: Remove implicit flooring in skia rect conversion methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ToNearestRect Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/view_unittest.cc

diff --git a/ui/views/view_unittest.cc b/ui/views/view_unittest.cc

index 73d6a05c240a9249821e7a25b7c8e3f79bfd5092..122c6ce9309b85a3de3508b2acf555f2eb969240 100644

--- a/ui/views/view_unittest.cc

+++ b/ui/views/view_unittest.cc

@@ -2483,9 +2483,8 @@ TEST_F(ViewTest, ConvertRectWithTransform) {

EXPECT_EQ(gfx::Rect(25, 100, 40, 15), v2->ConvertRectToParent(rect));

// |v2| now occupies (20, 20) to (120, 70) in |widget|

- // There are some rounding of floating values here. These values may change if

- // floating operations are improved/changed.

- EXPECT_EQ(gfx::Rect(22, 60, 20, 7), v2->ConvertRectToWidget(rect));

+ EXPECT_EQ(gfx::Rect(22, 60, 21, 8).ToString(),

+ v2->ConvertRectToWidget(rect).ToString());

widget->CloseNow();

}