Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: runtime/vm/object.cc

Issue 11359151: Fix for issue 6623 - Canonicalize implicit static closure objects. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 14794)
+++ runtime/vm/object.cc (working copy)
@@ -3066,6 +3066,27 @@
}
+RawInstance* Function::implicit_static_closure() const {
+ if (IsImplicitStaticClosureFunction()) {
+ const Object& obj = Object::Handle(raw_ptr()->data_);
+ ASSERT(!obj.IsNull());
+ return ClosureData::Cast(obj).implicit_static_closure();
+ }
+ return Instance::null();
+}
+
+
+void Function::set_implicit_static_closure(const Instance& closure) const {
+ if (IsImplicitStaticClosureFunction()) {
+ const Object& obj = Object::Handle(raw_ptr()->data_);
+ ASSERT(!obj.IsNull());
+ ClosureData::Cast(obj).set_implicit_static_closure(closure);
+ return;
+ }
+ UNREACHABLE();
+}
+
+
RawCode* Function::closure_allocation_stub() const {
if (IsClosureFunction()) {
const Object& obj = Object::Handle(raw_ptr()->data_);
@@ -4170,6 +4191,13 @@
}
+void ClosureData::set_implicit_static_closure(const Instance& closure) const {
+ ASSERT(!closure.IsNull());
+ ASSERT(raw_ptr()->closure_ == Instance::null());
+ StorePointer(&raw_ptr()->closure_, closure.raw());
+}
+
+
void ClosureData::set_closure_allocation_stub(const Code& value) const {
ASSERT(!value.IsNull());
ASSERT(raw_ptr()->closure_allocation_stub_ == Code::null());
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698