Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11359146: Revert "Linux: change protobuf default option to allow building" (Closed)

Created:
8 years, 1 month ago by nyquist
Modified:
8 years, 1 month ago
Reviewers:
Nico, agl
CC:
chromium-reviews, MAD, nkostylev+watch_chromium.org, achuith+watch_chromium.org, amit, browser-components-watch_chromium.org, kinuko+watch, Ilya Sherman, haitaol1, dcaiafa+watch_chromium.org, cbentzel+watch_chromium.org, jar (doing other things), stevenjb+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, tzik+watch_chromium.org, chromium-apps-reviews_chromium.org, tim (not reviewing), derat+watch_chromium.org, wez+watch_chromium.org, Raghu Simha, sanjeevr, simonmorris+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, akalin, garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr., agl
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Revert "Linux: change protobuf default option to allow building" This reverts commit baefae90f294a981c973bffbdd3eccabfe796b6a. The change broke Chrome for Android because non-vanilla protobuf-lite Java files were generated. Original review: https://codereview.chromium.org/11228038/ TBR=phajdan.jr BUG=160256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -68 lines) Patch
M chrome/browser/chromeos/contacts/contact.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/drive.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/feedback/proto/annotations.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/feedback/proto/chrome.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/feedback/proto/common.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/feedback/proto/config.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/feedback/proto/dom.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/feedback/proto/extension.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/feedback/proto/math.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/feedback/proto/web.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/history/in_memory_url_index_cache.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/metrics/proto/study.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/metrics/proto/trials_seed.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/net/cert_logger.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/policy/proto/chrome_device_policy.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/policy/proto/device_management_backend.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/policy/proto/device_management_local.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/policy/proto/old_generic_format.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/report.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/metrics/proto/chrome_experiments.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/metrics/proto/chrome_user_metrics_extension.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/metrics/proto/histogram_event.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/metrics/proto/omnibox_event.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/metrics/proto/profiler_event.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/metrics/proto/system_profile.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/metrics/proto/user_action_event.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/safe_browsing/client_model.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/safe_browsing/csd.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/tools/build/generate_policy_source.py View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/speech/proto/google_streaming_api.proto View 1 chunk +1 line, -0 lines 0 comments Download
M dbus/test_proto.proto View 1 chunk +3 lines, -1 line 0 comments Download
M remoting/proto/audio.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/proto/control.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/proto/event.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/proto/internal.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/proto/mux.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/proto/video.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M sync/protocol/app_notification_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/app_setting_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/app_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/autofill_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/bookmark_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/client_commands.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/client_debug_info.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/device_info_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/encryption.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/experiments_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/extension_setting_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/extension_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/get_updates_caller_info.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/history_delete_directive_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/nigori_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/password_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/preference_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/search_engine_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/session_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/sync.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/sync_enums.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/test.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/theme_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M sync/protocol/typed_url_specifics.proto View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/protobuf/README.chromium View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/descriptor.proto View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/descriptor.pb.h View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/descriptor.pb.cc View 11 chunks +56 lines, -56 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nyquist
thakis@ / agl@: PTAL
8 years, 1 month ago (2012-11-12 19:31:49 UTC) #1
Nico
lgtm
8 years, 1 month ago (2012-11-12 19:33:44 UTC) #2
agl
8 years, 1 month ago (2012-11-12 19:34:19 UTC) #3 
Rubber stamp LGTM for straight revert.

Powered by Google App Engine
This is Rietveld 408576698