Make sure Java Bridge cleans up all stub object it creates.

content/browser/renderer_host/java/java_bridge_dispatcher_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_JAVA_JAVA_BRIDGE_DISPATCHER_HOST_H_
 #define CONTENT_BROWSER_RENDERER_HOST_JAVA_JAVA_BRIDGE_DISPATCHER_HOST_H_
 
+#include <vector>
 #include "base/memory/ref_counted.h"
+#include "base/memory/weak_ptr.h"
 #include "base/string16.h"
+#include "content/common/npobject_stub.h"
 #include "content/public/browser/render_view_host_observer.h"
 
 class RouteIDGenerator;
 struct NPObject;
 
 namespace content {
 class NPChannelBase;
 class RenderViewHost;
 struct NPVariant_Param;
 
@@ skipping 33 matching lines @@
   // RenderViewHostObserver override:
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
 
   // Message handlers
   void OnGetChannelHandle(IPC::Message* reply_msg);
 
   void GetChannelHandle(IPC::Message* reply_msg);
   void CreateNPVariantParam(NPObject* object, NPVariant_Param* param);
   void CreateObjectStub(NPObject* object, int route_id);
 
+  static void CleanUpStubs(std::vector<base::WeakPtr<NPObjectStub> > stubs_);

[joth, 2012/11/14 00:51:27]

as this is a helper for the d'tor, no need for it to live on the class -- I'd
just put this into the .cc in an anonymous namespace.
Also I think |stubs| can be a const reference?
(Note - no underscore in param name)

[acleung, 2012/11/15 22:39:40]

Great idea.

+
   scoped_refptr<NPChannelBase> channel_;
   bool is_renderer_initialized_;
+  std::vector<base::WeakPtr<NPObjectStub> > stubs_;
 
   DISALLOW_COPY_AND_ASSIGN(JavaBridgeDispatcherHost);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_JAVA_JAVA_BRIDGE_DISPATCHER_HOST_H_