Add default icon to app_host.exe, and use it in shortcuts during installation.

chrome/installer/util/shell_util.h

Index: chrome/installer/util/shell_util.h
diff --git a/chrome/installer/util/shell_util.h b/chrome/installer/util/shell_util.h
index b521527f9f3e6020bf76d3b704e01fea0e90cad8..0f64f3d182659afbd934d95cca3f235d24741fdc 100644
--- a/chrome/installer/util/shell_util.h
+++ b/chrome/installer/util/shell_util.h
@@ -312,12 +312,10 @@ class ShellUtil {
       const ShellUtil::ShortcutProperties& properties,
       ShellUtil::ShortcutOperation operation);
 
-  // This method appends the Chrome icon index inside chrome.exe to the
-  // chrome.exe path passed in as input, to generate the full path for
-  // Chrome icon that can be used as value for Windows registry keys.
-  // |chrome_exe| full path to chrome.exe.
-  static string16 GetChromeIcon(BrowserDistribution* dist,
-                                const string16& chrome_exe);
+  // Combines |resource_path| with |resource_index| into a string that can be
+  // used as value for Windows registry keys.
+  static string16 GetResourceString(const string16& resource_path,

[gab, 2012/11/14 18:47:32]

Make resource_path a const FilePath&.

[huangs, 2012/11/14 20:35:55]

Many callers only have chrome_exe as string16.  I think we should refactor
ShellUtil.cc to use FilePath for these as much as possible -- but not in this
CL?

[gab, 2012/11/14 21:34:34]

I agree (it's already an item in the fixit), but this is not chrome_exe, it's
the resource_path (I'm thinking about some of the callers that have a path and
do .value() to call this method as it is now...).

[gab, 2012/11/14 23:47:07]

Ping

[huangs, 2012/11/15 00:06:38]

There are many callers in shell_util.cc that only has chrome_exe as a string16,
and only after several layers did it reach a FilePath.  So I figured the
refactoring should be saved for later (I'll do it if you want).

[gab, 2012/11/15 15:04:07]

Ok, fine like this for now, this really needs to be fixed in general :(.

+                                    int resource_index);
 
   // This method returns the command to open URLs/files using chrome. Typically
   // this command is written to the registry under shell\open\command key.