Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5166)

Unified Diff: chrome/installer/util/browser_distribution.cc

Issue 11359133: Add default icon to app_host.exe, and use it in shortcuts during installation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix .gypi for new file. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/browser_distribution.cc
diff --git a/chrome/installer/util/browser_distribution.cc b/chrome/installer/util/browser_distribution.cc
index 26f5a2f9b0c7994d9f84ad8a8329965bd66c4574..d6dfd617115bd473d58e91c4516b0bffe4404999 100644
--- a/chrome/installer/util/browser_distribution.cc
+++ b/chrome/installer/util/browser_distribution.cc
@@ -225,7 +225,13 @@ bool BrowserDistribution::CanCreateDesktopShortcuts() {
return true;
}
+string16 BrowserDistribution::GetIconFile() {
+ return string16();
+}
+
int BrowserDistribution::GetIconIndex() {
+ // Assuming that main icon appears first alphabetically, e.g.,
+ // as IDR_MAINFRAME.
gab 2012/11/14 18:47:32 Does IDR_MAINFRAME still apply here? Either way p
huangs 2012/11/14 20:35:55 Done. (FYI "e.g." is always directly followed by a
gab 2012/11/14 21:34:34 Ah ok, thanks for the grammar tip :), and thanks f
return 0;
}

Powered by Google App Engine
This is Rietveld 408576698