Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: chrome/browser/shell_integration_win.cc

Issue 11359133: Add default icon to app_host.exe, and use it in shortcuts during installation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: More renames and comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/shell_integration_win.cc
diff --git a/chrome/browser/shell_integration_win.cc b/chrome/browser/shell_integration_win.cc
index 32790758ac80e8dca1611102a0d4ba660584e21b..3c427c190ffc1515c1a39eab9e104b096a387eff 100644
--- a/chrome/browser/shell_integration_win.cc
+++ b/chrome/browser/shell_integration_win.cc
@@ -425,20 +425,18 @@ string16 ShellIntegration::GetAppListAppModelIdForProfile(
profile_path);
}
-string16 ShellIntegration::GetChromiumIconPath() {
+string16 ShellIntegration::GetChromiumIconString() {
// Determine the app path. If we can't determine what that is, we have
gab 2012/11/14 21:34:34 s/app path/path to chrome.exe
huangs 2012/11/14 21:57:01 Done.
// bigger fish to fry...
- FilePath app_path;
- if (!PathService::Get(base::FILE_EXE, &app_path)) {
+ FilePath chrome_exe;
+ if (!PathService::Get(base::FILE_EXE, &chrome_exe)) {
NOTREACHED();
return string16();
}
- string16 icon_path(app_path.value());
- icon_path.push_back(',');
- icon_path += base::IntToString16(
+ return ShellUtil::GetIconString(
+ chrome_exe.value(),
BrowserDistribution::GetDistribution()->GetIconIndex());
- return icon_path;
}
void ShellIntegration::MigrateChromiumShortcuts() {

Powered by Google App Engine
This is Rietveld 408576698