Add default icon to app_host.exe, and use it in shortcuts during installation.

chrome/installer/setup/install_worker.cc

Index: chrome/installer/setup/install_worker.cc
diff --git a/chrome/installer/setup/install_worker.cc b/chrome/installer/setup/install_worker.cc
index 2ef5660e3141f79a088857e02643586f4d49fd5a..860baf57a6d85418f86fd3c66845452cb79e07ec 100644
--- a/chrome/installer/setup/install_worker.cc
+++ b/chrome/installer/setup/install_worker.cc
@@ -621,12 +621,10 @@ void AddUninstallShortcutWorkItems(const InstallerState& installer_state,
                                          install_path.value(),
                                          true);
 
-    // TODO(huangs): Generalize this, so app_host.exe can get its own icon,
-    // and not rely on chrome.exe's.
     // DisplayIcon, NoModify and NoRepair
+    BrowserDistribution* dist = product.distribution();
     string16 chrome_icon = ShellUtil::GetChromeIcon(

[grt (UTC plus 2), 2012/11/13 16:19:32]

why not just ShellUtil::GetChromeIcon(dist).value()?  GetChromeIcon should call
both GetIconFile and getIconIndex.

[huangs, 2012/11/13 20:41:54]

This would be nice, but there are flows where chrome_exe is obtained from the
current process, and is then passed to this routine to get icons.

-        product.distribution(),
-        install_path.Append(installer::kChromeExe).value());
+        dist, install_path.Append(dist->GetIconExe()).value());

[erikwright (departed), 2012/11/13 14:55:34]

gab: This callsite is the main motivation for the new method on
BrowserDistribution.

Other options:

1) Add it to Product/ProductOperations instead.
2) Add an 'if (app_launcher) { ... } else { // chrome }' block here

[huangs, 2012/11/13 20:41:54]

Pending decision.

     install_list->AddSetRegValueWorkItem(reg_root, uninstall_reg,
                                          L"DisplayIcon", chrome_icon, true);
     install_list->AddSetRegValueWorkItem(reg_root, uninstall_reg,