Add default icon to app_host.exe, and use it in shortcuts during installation.

chrome/installer/util/chrome_frame_distribution.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines a specific implementation of BrowserDistribution class for
 // Chrome Frame. It overrides the bare minimum of methods necessary to get a
 // Chrome Frame installer that does not interact with Google Chrome or
 // Chromium installations.
 
 #include "chrome/installer/util/chrome_frame_distribution.h"
@@ skipping 94 matching lines @@
          L"Google Chrome Frame";
 }
 
 string16 ChromeFrameDistribution::GetVersionKey() {
   string16 key(google_update::kRegPathClients);
   key.append(L"\\");
   key.append(kChromeFrameGuid);
   return key;
 }
 
+string16 ChromeFrameDistribution::GetIconFile() {
+  return installer::kChromeExe;
+}
+
+int ChromeFrameDistribution::GetIconIndex() {
+  return 0;

[gab, 2012/11/14 18:47:32]

Why does chrome_frame override this to 0 (the default already) and not other
distributions which also use 0.

I feel everyone should override this (or nobody... in which case why do we have
it?!).

[huangs, 2012/11/14 20:35:55]

GoogleChromeSxSDistribution uses non-0.  I was expecting that ChromeFrame would
have something different, and was surprised that it uses Chrome's.  So I
overloaded the functions to make this explicit.

+}
+
 bool ChromeFrameDistribution::CanSetAsDefault() {
   return false;
 }
 
 bool ChromeFrameDistribution::CanCreateDesktopShortcuts() {
   return false;
 }
 
 bool ChromeFrameDistribution::GetCommandExecuteImplClsid(
     string16* handler_class_uuid) {
   return false;
 }
 
 void ChromeFrameDistribution::UpdateInstallStatus(bool system_install,
     installer::ArchiveType archive_type,
     installer::InstallStatus install_status) {
 #if defined(GOOGLE_CHROME_BUILD)
   GoogleUpdateSettings::UpdateInstallStatus(system_install,
       archive_type, InstallUtil::GetInstallReturnCode(install_status),
       kChromeFrameGuid);
 #endif
 }