Add default icon to app_host.exe, and use it in shortcuts during installation.

chrome/browser/shell_integration_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/shell_integration.h"
 
 #include <windows.h>
 #include <shobjidl.h>
 #include <propkey.h>
 #include <propvarutil.h>
@@ skipping 407 matching lines @@
            dist, InstallUtil::IsPerUserInstall(chrome_exe.value().c_str())),
       profile_path);
 }
 
 string16 ShellIntegration::GetAppListAppModelIdForProfile(
     const FilePath& profile_path) {
   return ShellIntegration::GetAppModelIdForProfile(kAppListAppName,
                                                    profile_path);
 }
 
 string16 ShellIntegration::GetChromiumIconPath() {

[gab, 2012/11/14 18:47:32]

Also rename this method to "...String" instead of "Path" for same reasons?

[huangs, 2012/11/14 20:35:55]

Done, leading to new changes in the .h file and browser.cc.

   // Determine the app path. If we can't determine what that is, we have
   // bigger fish to fry...
   FilePath app_path;

[gab, 2012/11/14 18:47:32]

s/app_path/chrome_exe

For consistency with how we name this path (base::FILE_EXE) across the codebase.

[huangs, 2012/11/14 20:35:55]

Done.

   if (!PathService::Get(base::FILE_EXE, &app_path)) {
     NOTREACHED();
     return string16();
   }
 
-  string16 icon_path(app_path.value());
-  icon_path.push_back(',');
-  icon_path += base::IntToString16(
-      BrowserDistribution::GetDistribution()->GetIconIndex());
-  return icon_path;
+  return ShellUtil::GetResourceString(
+      app_path.value(), BrowserDistribution::GetDistribution()->GetIconIndex());
 }
 
 void ShellIntegration::MigrateChromiumShortcuts() {
   if (base::win::GetVersion() < base::win::VERSION_WIN7)
     return;
 
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
       base::Bind(&MigrateChromiumShortcutsCallback));
 }
@@ skipping 18 matching lines @@
     }
 
     shortcut = shortcut.Append(shortcut_name).Append(shortcut_name +
                                                      installer::kLnkExt);
     if (file_util::PathExists(shortcut))
       return shortcut;
   }
 
   return FilePath();
 }